smonetti/btbutton

CKEditor4 Bootstrap3 button widget

btbutton's Issues

Add font-awesome, glyphicon css support to plugin

Some CMS which use that plugin may not use Bootstrap for editing content.
As a result - Bootstrap buttons provided by plugin will not have desired styles in CKeditor.

We can use cdn to attach needed css.

button grayed out?

for me the button is always grayed out, unless i enable widgetbootstrap for some reason. What's the dealio? (cool plugin btw)

Font Awesome / Glyphicon classes not being applied

I've tried the different settings for buttons and all of them seem to work with the exception of the icons tab options. Adding an icon name to either FA/Glyphicon fields doesn't change the tag output, so no icon is produced. I'm using CKEditor 4.3.5 in Expression Engine 2.9. We already use Font Awesome on our site so seeing that supported is great. Is there something I'm missing to make the proper classes/html appear for icons?

Attribute "href" doesn't change

Changing the URL option in dialog settings doesn't have any effect in the href attribute of the element.
I found a solution removing the attribute 'data-cke-saved-href' after changing the href in plugin.js.

if (this.data.href) { $el.attr('href', this.data.href); this.element.$.removeAttribute('data-cke-saved-href'); }

CKeditor release

@smonetti thanks for merging PR #9. Any chance we could roll a new release for the ckeditor add-ons (https://ckeditor.com/addon/btbutton). Thanks.

When I edit the button it goes back to default settings

I even tried the demo on your site. Creating a button works great but if you go to make changes, some times it works then suddenly it is back to the default settings.

Outline options

It would be good to be able to use the outline version

https://getbootstrap.com/docs/4.0/components/buttons/#outline-buttons

Cheers

After changing a button size, can't change size back to normal.

To reproduce

Create a button, select a size option other than Normal (Extra Small, Small, Large)
Click OK
The button is sized.
Reopen the button properties dialog and switch the button back to size Normal.
Click OK
The button size doesn't change.

Resolution

This can be resolved by changing plugin.js near line 35
From:

if (this.data.btnsize) {
    $el.removeClass('btn-xs btn-sm btn-lg').addClass(this.data.btnsize);
}

To:

$el.removeClass('btn-xs btn-sm btn-lg');
if (this.data.btnsize) {
   $el.addClass(this.data.btnsize);
}

Add "aria-label" attribute within ckeditor

Hi, here is a patch to add aria-label field for Bootstrap Buttons
.

It is adding   in every edit if there is a icon right

Every time that there is a icon on the right, it is adding a   that is converted from the \n added at the end of the i append. It happens in every edit or every "Source" view.

Add pt-br translation

pt-br_translate.patch.zip

Bootstrap 4 support

Does the plugin work with Bootstrap 4?