snehesht/blog

Minimalist database less blog engine

blog's Issues

500 Error When Non existent url is requested

• When you go to a non existent url, the application fails like so

• This is because in the finally block below when no url is found data[bp['file']] has no value.

# app/views.py
def blog_post(url_slug):
    data = DS.get_data()
    metadata = DS.get_metadata()
    bp = {}
    try:
        # ISSUE-1a: If below raises an exception
        for item in metadata:
            # Search for metadata of the blogpost with that url
            if item['url'] == url_slug:
                bp = item
    except Exception as e:
        # No such blogpost
        return redirect(url_for('index_page'))
    finally:
        #  ISSUE-1b: 'bp' is still and empty dict  
        raw_content = data[bp['file']]
        processed_content = Markup(markdown.markdown(raw_content))
        return render_template('blog_post.html', content=processed_content,metadata=bp)

• Here is a proposed solution with future things to look out for

def blog_post(url_slug):
    data = DS.get_data()
    metadata = DS.get_metadata()
    bp = {}

    # Search for metadata of the blogpost with that url
    bp = [item for item in metadata if item['url'] == url_slug]

    if not bp:
        # No such blogpost
        return redirect(url_for('blog_index_page'))
    else:
           # TODO: Decide how to handle multiple blog posts with the same title
           # Idea: During data load/reload, throw an error if duplicate title is found
        bp = bp.pop(0)
        raw_content = data[bp['file']]
        processed_content = Markup(markdown.markdown(raw_content))

        return render_template('post.html', content=processed_content, metadata=bp)

Cleanup non issue

When my account was compromised a spam issue was created in this repo. I sincerely apologize. Cleaning up such issues via script.