snsinfu/deno-oauth-1.0a

OAuth 1.0a Request Authorization for deno

deno-oauth-1.0a's Issues

Cannot reproduce an RFC example

The test case OAuthClient.sign - produces correct HMAC-SHA1 signature (RFC) added in a7168ad fails. The signature base string looks correct (verified in a test case for getBaseString). So, it could be a bug in a signature computation.

Strangely, a test case inherited from ddo/oauth-1.0a succeeds. In that test case an HMAC-SHA1 signature is computed. But without token secret (as opposed to the failing test case).

Maybe something is wrong with the handling of token secret in the current implementation.

Request-based API

As a deno library, it would be more natural to sign a Request object than an ad-hoc method-url pair (plus opts.body). The sign function should look like:

sign(req: Request, opts?: SignOptions): Request;

This way, I can compose a fully customized request object, sign it and immediately pass the result to the fetch function:

const request = new Request(url, {
  method: "POST",
  headers: {
    "Content-Type": "application/json",
    "X-API-Version": "1",
  },
  body: JSON.stringify(data),
});
const response = await fetch(
  client.sign(request, { token: userToken })
);

Docs on the Request class:

• https://doc.deno.land/builtin/stable#Request
• https://developer.mozilla.org/en-US/docs/Web/API/Request