sob7i/hyf-javascript2

hyf-javascript2's Issues

No book cover images added!

You have not added any book cover images to your homework.

https://github.com/Sob7i/hyf-javascript2/blob/0dd82a96c959e7173aae9a2442234c9f80d18690/Week%201/app.js#L203

Correct key not being used to retrieve data!

In this function, you are not using the correct keys ('title', 'language' and 'author'). Capitalising the first letter of the key changes the key because JavaScript is case-sensitive. Hence, when you try to retrieve the title of the book on line 184 using boTi.innerHTML = bookDet[bookId].Title; it would not work. The correct way to write this would be boTi.innerHTML = bookDet[bookId].title;

hyf-javascript2/Week 1/app.js

Lines 166 to 200 in 0dd82a9

	function bookTit(){
	let booksInfo = document.createElement("ul");
	document.body.appendChild(booksInfo);
	for (let bookId in bookDet ) {
	let bookT2 = document.createElement("li");
	bookT2.setAttribute("id",bookId);
	booksInfo.appendChild(bookT2);
	let boTi = document.createElement("h2");
	bookT2.appendChild(boTi);
	boTi.innerHTML = bookDet[bookId].Title ;
	let boLa = document.createElement("p");
	bookT2.appendChild(boLa);
	boLa.innerHTML = bookDet[bookId].Language;
	let boAu = document.createElement("p");
	bookT2.appendChild(boAu);
	boAu.innerHTML = bookDet[bookId].Author;
	};
	}

Script tag incorrect, so script is never attached!

The 'src' attribute is present outside the tag definition.

hyf-javascript2/Week 1/index.html

Line 12 in 0dd82a9

<script> src="app.js" </script>

Two functions with the same name!

You have made two functions with the exact same name 'bookTit()'. Due to this, the second function is called when you try to call the first function. Also, the second function never runs because the object 'bookDet' is defined after the function is being called for the first time.

hyf-javascript2/Week 1/app.js

Lines 31 to 49 in 0dd82a9

	function bookTit() {
	let bookT1 = document.createElement("ul");
	for (i = 0; i < bookTitles.length; i++) {
	let bookT2 = document.createElement("li");
	bookT1.appendChild(bookT2);
	bookT2.innerHTML = booksTitels[i];
	}
	}
	console.log(bookTit());

Keys are in double-quotes!

The keys in the function are in double quotes and due to this, the function 'bookTit()' is never able to retrieve any data.

hyf-javascript2/Week 1/app.js

Lines 56 to 160 in 0dd82a9

	let bookDet = {
	"Zuleika_ Dobson": {
	"title": "Zuleika_ Dobson",
	"language": "English",
	"author": "Max_Beerbohm"
	},
	" The_Good_Soldier": {
	"title": " The_Good_Soldier",
	"language": "English",
	"author": "Madox_Ford "
	},
	"The_Thirty_Nine_Steps": {
	"title": "The_Thirty_Nine_Steps",
	"language": "English",
	"author": " John_Buchan"
	},
	"The_Rainbow": {
	"title": "The_Rainbow",
	"language": "English",
	"author": "DH_Lawrence "
	},
	"of_Human_Bondage": {
	"title": "of_Human_Bondage",
	"language": "English",
	"author": "W_Somerset_Maugham "
	},
	"The_Age_of_Innocence": {
	"title": "The_Age_of_Innocence",
	"language": "English",
	"author": "Edith_Wharton"
	},
	"Ulysses": {
	"title": "Ulysses",
	"language": "English",
	"author": " James_Joyce"
	},
	" Babbitt": {
	"title": " Babbitt",
	"language": "English",
	"author": "Sinclair_Lewis "
	},
	" A_Passage_to_India": {
	"title": " A_Passage_to_India",
	"language": "English",
	"author": "EM_Forster"
	},
	"Gentlemen_Prefer_Blondes": {
	"title": "Gentlemen_Prefer_Blondes",
	"language": "English",
	"author": "Anita_Loos"
	}
	};