Giter Site home page Giter Site logo

Comments (7)

softprops avatar softprops commented on August 17, 2024

Can you share a link to your workflow? There's nothing in particular we do to manage your working directories. I believe the configuration option you mentioned simply switches the working directory before running the action rather than providing the job steps' working-directory input

from action-gh-release.

jerryc05 avatar jerryc05 commented on August 17, 2024

here is an excerpt, hope this helps:


jobs:
  build_and_deploy:
    runs-on: ubuntu-latest
    defaults:
      run:
        working-directory: ./frontend

    steps:
      - uses: actions/checkout@v4

      - uses: pnpm/action-setup@v4
        with:
          version: latest
          run_install: false

      - shell: bash
        run: |
          echo "STORE_PATH=$(pnpm store path --silent)" >> $GITHUB_ENV

      - uses: actions/cache@v4
        with:
          path: ${{ env.STORE_PATH }}
          key: ${{ runner.os }}-pnpm-store-${{ hashFiles('**/pnpm-lock.yaml') }}
          restore-keys: |
            ${{ runner.os }}-pnpm-store-

      - run: pnpm i

      - name: Build
        run: pnpm run dist

      - name: Deploy to GitHub release
        uses: softprops/action-gh-release@v2
        with:
          files: frontend/dist/*.zip
          tag_name: zipped_dist

where pnpm run dist command packages everything into a zip file.

If this workflow looks good to you, I can try to provide a minimal reproducible repo.

from action-gh-release.

softprops avatar softprops commented on August 17, 2024

I think I see the issue

the following settings the working directory for each step. think of it like the PWD path when executing a step

    defaults:
      run:
        working-directory: ./frontend

In your files declaration you provide the patternfrontend/dist/*.zip which will be resolved while you are in the frontend directory which would assume a path more like frontend/frontend/dist/*.zip because its relative to the working-directory for the step.

      - name: Deploy to GitHub release
        uses: softprops/action-gh-release@v2
        with:
          files: frontend/dist/*.zip

Could you try and remove the frontend prefix from that step? Since the working-directory is frontend that would then resolve to something like frontend/dist/*.zip

      - name: Deploy to GitHub release
        uses: softprops/action-gh-release@v2
        with:
          files: dist/*.zip

from action-gh-release.

jerryc05 avatar jerryc05 commented on August 17, 2024

afaik,

        with:
          files: frontend/dist/*.zip

is working (current working version of my workflow), but

        with:
          files: dist/*.zip

does not work (cannot find anything matching *.zip) (my initial not-working version)

from action-gh-release.

softprops avatar softprops commented on August 17, 2024

What happens when you remove the frontend part of the path after setting the working directory to frontend?

from action-gh-release.

jerryc05 avatar jerryc05 commented on August 17, 2024

IMG_0627

from action-gh-release.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.