Giter Site home page Giter Site logo

iOS: `Screen` with `{ presentation: "modal" }` navigated to from within another react-native's `Modal` doesn't open about react-native-screens HOT 8 CLOSED

bbarthec avatar bbarthec commented on May 27, 2024 4
iOS: `Screen` with `{ presentation: "modal" }` navigated to from within another react-native's `Modal` doesn't open

from react-native-screens.

Comments (8)

kkafar avatar kkafar commented on May 27, 2024 2

yeah, I see why that's happening, thanks for reporting! We will include a fix in incoming release

from react-native-screens.

kimlesieur avatar kimlesieur commented on May 27, 2024 2

@kkafar Any news on an incoming fix ? I have a similar issue that I think could be related to this one :)

from react-native-screens.

hollanderbart avatar hollanderbart commented on May 27, 2024 2

The issue I described (#2085) is similar to this issue. Any news on the potential fix?

from react-native-screens.

kkafar avatar kkafar commented on May 27, 2024 1

Excuse me for late response, @hollanderbart, #2113 should resolve the issue.
If you have capacity, I would like to get feedback & confirmation that the patch works also in your case.

You can test out the patch by installing react-native-screens directly from GitHub, by putting following in your package.json:

"react-native-screens": "software-mansion/react-native-screens#@kkafar/fix-presenting-from-react-native-modal"

(watch for typos, as I'm writing from memory 😅)

from react-native-screens.

hollanderbart avatar hollanderbart commented on May 27, 2024 1

Thanks @kkafar I will test it out and come back to you on this.

from react-native-screens.

hollanderbart avatar hollanderbart commented on May 27, 2024

@kkafar Can you please let us know when a possible fix is planned? Thanks!

from react-native-screens.

hollanderbart avatar hollanderbart commented on May 27, 2024

I've tested it and your fix works! 🎉

Thanks again @kkafar
I suppose you can merge this fix.

from react-native-screens.

kkafar avatar kkafar commented on May 27, 2024

Great, thanks for checking it out!

from react-native-screens.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.