solana-labs/obsolete-dontuse-example-webwallet

Example Solana Web-based Wallet

obsolete-dontuse-example-webwallet's Issues

Can't sign a transaction with a Ledger device

Problem

Currently, transactions are signed with an insecure and temporary, in-browser keypair.

Proposed solution

Sign transactions with a keypair in a secure enclave, such as a Ledger Nano S.

https! Need it ASAP

Change confirm transaction input submit behavior

Problem

Submitting a transaction signature for confirmation causes a page refresh

Expected

No page refresh, submit an async request to confirm a valid transaction.

Steps to Reproduce

1. Enter a transaction signature
2. Press enter

Save and reload private key from browser password manager.

Wallet keys are ephemeral. While this is a burner wallet, we should store the keys. During account creation the browser could prompt the user to store the generated seed in the OS/Browser keychain as a regular password.

Fix transaction confirmation

Problem

The confirm transaction section is not working correctly. After pasting a valid transaction signature, the input validation shows an error.

Proposed Solution

• Check if the signature input validation is incorrectly using public key input validation (that's my guess)
• Add an error message to help users know why the signature was not considered valid

send button doesn't light up after an airdrop

login to message
add funds
airdrop to wallet
send is still greyed out

npm install failing

Getting this error, when going through installation steps

Example app: Web Wallet

00:19:17 ✔ pk: ((HEAD detached at v1.0.0)) example-webwallet $ npm install
npm ERR! code MODULE_NOT_FOUND
npm ERR! Cannot find module 'node-gyp/bin/node-gyp'

npm ERR! A complete log of this run can be found in:
npm ERR!     /Users/pk/.npm/_logs/2019-07-12T14_19_32_966Z-debug.log

QA current wallet functionality

I'd like it if a small group of people who understand the needs can QA current work and assess remaining gaps and bugs CC @jstarry Besides you, who else would be good to pull in for QA, stakeholder-wise? Happy to help here if there isn't anyone better..

Setup basic Travis CI

Update UI for token request screen

Failed transaction alert should not capitalize signature

Problem

The new alert design displays in all uppercase but signatures are case-sensitive.

Proposed Solution

Change CSS to not uppercase the error message

Use wallet.solana.com as a trusted display for hardware wallets

Forwarding an issue created by @aeyakovenko here: https://github.com/solana-labs/ledger-app-solana/issues/3

Problem

Hardware wallets require parsing and displaying messages inside the TPM to confirm the signing request.

Solution

We could use wallet.solana.com as a trusted display as well. Basically decode and show the hash and the transaction details in our hosted wallet, confirm the hash on the ledger. Users should confirm the transaction hash from another machine, like a mobile device.

If solana.com is compromised users would not be able to sign messages, but funds should remain secure as long as the local machine is not compromised either.

Another idea:

Maybe this is overkill, but the cli transactions could require a co-signature from the web wallet. The web wallet key is not referenced in any instructions, but the signature would force the user to look at the web wallet with their phone preferably.

Support embedded token requests

dApps should be able embed the web wallet in an iframe to request tokens. The web wallet should allow this and then communicate to the dApp that it should be closed (when transaction succeeds)

Network Explorer Dropdown

Designs in Figma:
Desktop: https://www.figma.com/file/VV63sXC9UbGAUczGOEOJVapn/Solana-Network-Explorer-MVP?node-id=2150%3A0
Mobile: https://www.figma.com/file/VV63sXC9UbGAUczGOEOJVapn/Solana-Network-Explorer-MVP?node-id=2281%3A3113 (we are working on a few more mobile screens for you)

Other items -->

• Alerts: https://www.figma.com/file/VV63sXC9UbGAUczGOEOJVapn/Solana-Network-Explorer-MVP?node-id=2519%3A138 + https://www.figma.com/file/VV63sXC9UbGAUczGOEOJVapn/Solana-Network-Explorer-MVP?node-id=2519%3A280
• Send Confirmation: https://www.figma.com/file/VV63sXC9UbGAUczGOEOJVapn/Solana-Network-Explorer-MVP?node-id=2540%3A56
• Loading State: https://www.figma.com/proto/VV63sXC9UbGAUczGOEOJVapn/Solana-Network-Explorer-MVP?node-id=2226%3A149&viewport=142%2C516%2C0.5&scaling=min-zoom (go to screen 4/6 and click request tokens to see). Animation can work like this: https://codepen.io/dalityg/pen/bXxxdj
  Desktop screens are pretty much done @shivani. Haven't built out all mobile ones but can create some of the key ones.