somuchforsubtlety/f1viewer

🏎️ TUI for F1TV

f1viewer's Issues

Can't play many videos including live sessions

I got the latest version, 1.1.
Getting the following error:
[ERROR] got status 400 Bad Request with body: {"skylark_error_code": null, "form_validation_errors": null, "error": "The content must have a schedule that matches the current schedule filters"}

$url substitution replaces original string

The replacement of $url in custom commands only works the first time it is triggered. Subsequent uses of the same custom command result in the previous url being returned again, as it has replaced the original string in the stored argument.

Update with authentication

Is there any possibility you can update the program using the official authentication method?
I could not find a way to download videos with ffmpeg now that it is restricted. Would love to do that again.

use os.UserConfigDir instead of custom logic

https://golang.org/pkg/os/#UserConfigDir

Race spoilers

Within the full info for full race weekends, the podium finishers appear as 'Winner1URL', 'Winner2URL' and 'Winner3URL'. Anyone using this tool to catchup on a very recent race will thus get the result spoiled.

":" in $name

I've noticed that when I try to use the new $name attribute I sometimes run into problems if the name contains ":" since windows does not like that in file names.
Maybe you could replace invalid characters?

Full list not loading somewhy

Some time ago tool stop loading full list and directories v0.7.3 win64

Use a custom video player and add an option for video quality for MPV

ww

option to lauch custom commands after each other instead of at the same time

Maybe on a command by command basis defined in the config

improve (or remove) .m3u8 download / modifying

Race spoilers (again)

Previously addressed in #3, but something is causing them to show up again. WinnerXURL appears in the Info pane when hovering over the name of a Grand Prix under "Full Race Weekends".

(As a side-request, perhaps a config option to just hide the info pane completely? Unless working on code development, it's fairly useless to end users in it's current state.)

Dealing with the Stdout of executed commands

Doesnt properly terminate at EOF and uses lots of CPU resources.
needs investigation

Add audio between pilot and engineer

I wanted to ask you if you could also add the conversations that are between pilots and engineers

F1viewer crash on startup

panic: runtime error: index out of range

goroutine 19 [running]:
main.getLiveNode(0xc000161fb0, 0x1, 0x1, 0x0)
        C:/Users/jakob/Documents/projects/F1/F1viewer/node.go:57 +0x72f
main.main.func1(0xc00012f2d0, 0xc000136000)
        C:/Users/jakob/Documents/projects/F1/F1viewer/main.go:128 +0x9b
created by main.main
        C:/Users/jakob/Documents/projects/F1/F1viewer/main.go:125 +0x5fc

Preseason Testing live coverage error

When trying to open the live stream for the pre season testing coverage the following error is returned:
[ERROR] {"form_validation_errors": null, "skylark_error_code": null, "error": "{"form_validation_errors": null, "skylark_error_code": null, "error": "driver_urls was not in the fields to be returned. Has it been filtered out? (Available fields: name, self)"}"}

The current live session is also not reported as a live session: "no live session found"

Way to possible load custom .lua scripts for mpv

Any way to launch custom .lua scripts with action MPV?

Currently i trying launch script https://gitlab.com/lvml/mpv-plugin-excerpt with config

	{
            "title": "Play with MPV (Lua script)",
            "commands": [
		["mpv", "$url", "--alang=de --lua excerpt.lua"]
            ],
            "watchphrase": "Video",
            "command_to_watch": 0
        }

Scripts excerpt.lua and excerpt_copy placed in same directory as mpv/ffmpeg and commandline tell its loaded mpv https://f1tv-cdn-cent-live.formula1.com/ondemand/ce1c/_C_/3/2/wif0630041637/1/clip_2_master.m3u8?nva=1562911769&ttl=86400&cc=&token=0a6cfda24a469e6be08aa "--alang=de --lua excerpt.lua", but script not work.

Don't work at windows 10 1909

Don't work and crash after open any full race. MPV player is updated. Try to download .m3u8 gives nothing its don't download and cant get URL.

F1TV requires authentican to generate streamable URL

After updating to Catalina, I now get the following errors

Any ideas?

$name for commands

I would really like to have the name of the event i'm playing as a variable when issuing a command. For example if i'm playing back the "Formula 1 Gran Premio De Mexico - F1 Race - Main Feed" i would like to have the $name parameter to be exactly that. This would make saving files a lot more convenient.

Thanks in advance.

Login/2019 Season

Good Morning ;)

I've been looking into an easy way to watch/stream F1 on my linux machine. Managed to compile this, got it running too.

2 questions: So far I don't see the 2019 FP1, the VOD on f1tv is already there though.

How would I log in? I didn't see any way to actually input my credentials for f1tv. Or am I completely missing something here?

Sorry for the beginner questions. :)

APIs for F1Viewer

What APIs are you using for this project? Where it's possible to read their documentations?

[New Feature] F1TV Now has 50fps 720p streams on a different URL/api

Via this URL a different (more basic) player is used that only shows the main feed, however it has 1280x720 at 50fps.

https://f1tv.formula1.com/dr/index.html

and this url nets you a JSON file with an m3u8 url: https://f1tv.formula1.com/dr/stream.json

[BUG] The content must have a schedule that matches the current schedule filters

Describe the bug
Error received trying to playback anything from Austrian live event this weekend. Old content plays OK.
2020/07/03 12:13:49 [ERROR] got status 400 Bad Request with body:
{"skylark_error_code": null, "form_validation_errors": null, "error": "The content must have a schedule that matches the current schedule filters"}

To Reproduce
Steps to reproduce the behavior:

1. Go to: 2020 Austrian Grand Prix Formula 2 Practice
   Main Feed
   │ ├──Play with MPV
2. Try to play
3. See error: [ERROR] got status 400 Bad Request with body:
   {"skylark_error_code": null, "form_validation_errors": null, "error": "The content must have a schedule that matches the current schedule filters"}

Expected behaviour
Playback to start in MPV player as per older items available to view.

Screenshots

Desktop (please complete the following information):

• OS Win10 Pro 64bit
• installation method: f1viewer_1.1.0_windows_64-bit.zip
• Version [Version: 1.1.0
  Git commit: b696393
  Built: 2020-06-29T15:28:49Z]

Logs
2020/07/03 12:13:32 [INFO] logged in!
2020/07/03 12:13:32 [INFO] checking for live session
2020/07/03 12:13:49 [ERROR] got status 400 Bad Request with body:
{"skylark_error_code": null, "form_validation_errors": null, "error": "The content must have a schedule that matches the current schedule filters"}

[NEW FEATURE] Show have a "Refresh" option so we can get ride of the Live Session when it ends

When a live session ends, it will stay there forever as it does not re-fetch the data... maybe adding a Refresh item to the end of the menu? or keep pooling every minute?

for now Ctrl + C and run again will do the trick 😉👌

add config option for UI proportion

F1viewer not play videos

https://prnt.sc/rdfkwn

Log file being created in user's current directory rather than executable location

The log file (log.txt) is created wherever the user was in their filesystem when they call f1viewer. I imagine this file to be created in the executable location, but setWorkingDirectory is not called until a few lines later.

If it's not possible for the location to be changed, then perhaps make logging to file a debug-only option?

m3u8 compatibility

First of all, thanks for not being subtle.

The .m3u8 files exported by the Viewer already had problems in VLC, but now they don't work with Kodi, which had been working until now. The error is "404" (according to Kodi log).

I tried adding the extra information that appears on the MPV titlebar/clip-name manually to the end of the URLs on the m3u8 but the response is the same. Can it be included in the .m3u8 somehow?

If not, maybe the next version can stop exporting .m3u8 or warning that compatibility is very limited?

Keep up the good work!

[BUG] Crash on Austrian GP Practice 1 List Options

Describe the bug
Similar Bug to #48. When I select the Austrian GP 2020, Practice 1 the program crashes.
Bug is also reintroduced on 2019 Full Race Weekends as in #48

To Reproduce
Steps to reproduce the behavior:
Select 2020 Austrian GP Practice 1

Expected behaviour
List options to play with mpv, copy url etc.

Desktop (please complete the following information):

• OS: Windows 10
• Downloaded v1.1.0 from Github
• Version 1.1.0

Logs

2020/07/03 13:09:43 [INFO] logged in!
2020/07/03 13:09:43 [INFO] checking for live session
2020/07/03 13:11:32 [INFO] logged in!
2020/07/03 13:11:32 [INFO] checking for live session
2020/07/03 13:12:15 [INFO] logged in!
2020/07/03 13:12:15 [INFO] checking for live session

Control on Windows

Hello,
how are you supposed to control the tool? On windows 10 it does not take any key inputs nor can I find any doc about it. I can log in but not select anything else.

F1viewer crashes

After few seconds it crashes, logs say there's missing config.json. Tried to create this config and nothing helped.
edit: Ok, i fixed config thing but it still crashes. logs are:
found 0 custom commands
checking for live session
no update available
That’s all, it worked for the whole 2019 season. It started crashing early 2020, yesterday after reinstall i’ve had that config problem however, i fixed it by saving the file as .json and it’s crashing again like in the past

Login with my own account?

I have an F1TV Pro account, trying to work out how to sign into this with my own account?

If it requires recompiling that's fine, I can do that.

No sound.

Hi,

I'm getting a video but it has no sound. Not sure if I'm missing something obvious but nothing I do seems to solve the issue.

Cheers

If a driver moves to a new team the team assignments in previous races are incorrect

better error handling

can crash when loading from API fails

Application won't launch; could not access credential store

Installed from Homebrew on MacOS 10.15. When I run f1viewer from the command line, it returns the error:
[ERROR] Could not access credential store: Specified keyring backend not available

Here's the log:
2020-03-14.log

MacOS login credentials not saved

f1viewer will not safe login credentials in de MacOS keychain.
After selecting save it'll log in, and then give a 'No keyring configured' message.
I'm running MacOS catalina on both machines I'm having this issue on.

[NEW FEATURE] Be able to specify the max resolution for not-so-fast connections

from a Redit user

The app works great, but is there an option to change stream resolution? My internet connection can't sustain three 1080p streams, and I don't need full resolution for all the streams anyway.

original message

ERROR: got status 400 Bad Request with body

Hello, I can't play any Formula 1 steams. https://prnt.sc/rdfkwn

Live session stoped show as first in list

[BUG]

The exact error: tls: handshake failed: error:14FFF3E7:SSL routines:(UNKNOWN)SSL_internal:unknown failure occurred

MPV sometimes has issues with some stream (2020-any race-Main Feed). It gives an TLS error. Tried this with the most recent MPV and f1Viewer.

My suggestion would be to switch to VLC, or make it possible to choose the rendered in the config.json file.

Add option to select audio and video track if multiple are available

use ffprobe get options, then select one

My player cannot read the m3u8

I do not know why it no longer works. F1viewer can get the m3u8 file easily but my video player cannot connect to the server of liberty.

this happens on pretty much any video in 2019, some in 2018. But for instance the padock pass plays well. I tried on two different computers with different ISPs and I disable the windows firewall.
this is the data.m3u8 i try to play

in my player, I paste also the ''FullStreamURL'' of the stream i seek but that fails too. i try one fo the URL written in the m3u8 file directly, and it fails too.

I also try with the MPV player and the data stream is played

I also tried on portable vlc, VLCPortable_3.0.7.paf stock settings and it does not work. I can play other m3u8 files non-related to f1 without problem.

403 Issues

Do I add my cookie/login credentials somewhere, or how this works?

Decide on a strategy for sanitizing file names

Maybe a config value that enumerates illegal characters (or regex?) that's set to the operating systems forbidden characters by default.

Change video quality in MPV

I play the video in MPV and they are all in 1080p. Is it possible to get the other streams like 720p, 576p ?

Detect potential geoblocking and show warning message

Need help...

-deleted-

Crash on Full Race Weekend Race Video List

Describe the bug
When trying to list the playback options for a race of the type "Full Race Weekend" the program crashes. Full Races (not the whole weekend) (pre 2018) work just fine.

To Reproduce
Steps to reproduce the behaviour:

1. Go to 'Full Race Weekend > 20xx F1 Championship > xx Grand Prix > Race > Crash'

Expected behaviour
List the options for the race.

Screenshots

loading... and then crashes.

Desktop (please complete the following information):

• Windows 10 2004 (Build 19041.329)
• Latest release binary and go build on lastest master
• Version 1.0.0 and dev

Logs
These are the logs repeating the crash a few times. Nothing to speak of really.

2020/06/10 15:59:15 [INFO] logged in!
2020/06/10 15:59:15 [INFO] checking for live session
2020/06/10 15:59:18 [INFO] no live session found
2020/06/10 15:59:36 [INFO] logged in!
2020/06/10 15:59:36 [INFO] checking for live session
2020/06/10 15:59:38 [INFO] no live session found
2020/06/10 16:02:34 [INFO] logged in!
2020/06/10 16:02:34 [INFO] checking for live session
2020/06/10 16:02:37 [INFO] no live session found
2020/06/10 16:04:43 [INFO] logged in!
2020/06/10 16:04:43 [INFO] checking for live session
2020/06/10 16:04:44 [INFO] New version found!
2020/06/10 16:04:46 [INFO] no live session found
2020/06/10 16:39:38 [INFO] logged in!
2020/06/10 16:39:38 [INFO] checking for live session
2020/06/10 16:39:39 [INFO] New version found!
2020/06/10 16:39:40 [INFO] no live session found

Can't open it on Mac

Do I need a program to open it? I can't find out what program I need