View Code? Open in Web Editor
NEW
JavaScript module for Israeli Bank Account validation (sanity checking) if an account number is valid for a particular Israeli bank and branch.
Home Page: https://www.npmjs.com/package/il-bank-account-validator
License: MIT License
il-bank-account-validator's People
Contributors
Watchers
il-bank-account-validator's Issues
Jerusalem bank is number 54.
Currently it always returns true
.
Investigate this.
- Generate a set of valid values & their pairings manually from specification
- Write test suite & test cases (Mocha?)
How does one identify edge cases?
|
case(10): // Luemi |
|
case(13): // Igud |
|
case(34): // Aravei Israeli merged with 10 |
|
sum += accountNumberDigits[0] * 2; |
|
sum += accountNumberDigits[1] * 3; |
|
sum += accountNumberDigits[2] * 4; |
|
sum += accountNumberDigits[3] * 5; |
|
sum += accountNumberDigits[4] * 6; |
|
sum += accountNumberDigits[5] * 7; |
|
sum += accountNumberDigits[0]; |
|
sum += accountNumberDigits[1]; |
|
sum += branchNumberDigits[0] * 8; |
|
sum += branchNumberDigits[1] * 9; |
|
sum += branchNumberDigits[2] * 10; |
|
sum %= 100; |
|
return sum === 90 || sum === 72 || sum === 70 || sum === 60 || sum === 20; |
If I understand correctly, your code should be:
Line 133: sum += accountNumberDigits[6];
Line 134: sum += accountNumberDigits[7];