soto-archive/soto-s3

Standalone Repository of AWS S3 Client from soto-project/soto

soto-s3's Issues

Crash in S3RequestMiddleware (due to optional bang)

https://github.com/swift-aws/s3/blob/9deea717490c08c5dac87e8b818cbdb2b227c7e6/Sources/SwiftAWSS3/S3RequestMiddleware.swift#L40

We’re getting a crash here for filenames with spaces in them.

Our fix locally is to percent encode the key, but well, we should remove this bang, it's not safe. Either throw or percent encode ourselves (possibly thus percent encoding twice, not sure if there's a logical way to prevent that).

Happy to PR, LMK what you think.

Cannot download png image from s3

Hi,
I am using SwiftAWSS3, but it cannot download image - there is an exception throw in XML parsing

let s3Client = S3(accessKeyId: "",
                      secretAccessKey: "",
                      region: Region.eucentral1,
                      endpoint: "https://apigateway.eu-central-1.amazonaws.com"
    )
let request = S3.GetObjectRequest(bucket: bucketName, key: "2017/08/image-620x826.png")
let object = try s3Client.getObject(request)
            
if let body = object.body {
     return ImageResource(data: body)
}

This code can return image when I use another ServiceProtocol in S3 client creation

 ServiceProtocol(type: .other("image"))

Do I do something wrong?

`createBucket` request fails with 409 (conflict), but doesn't throw

When making a create bucket request for an already existing bucket the future succeeds but the operation in fact failed.

Stepping through the framework code in a debugger the first (or second) HTTP request is a 409, but the future is not rejected.