sowmya1408/hyf-homework

Hi My name is Sowmya Mannem

Frontend developer

I am a Frontend developer who loves React.

• 🌍  I'm based in Copenhagen
• ✉️  You can contact me at [email protected]
• 🚀  I'm currently working on Crwn Clothing App
• 🧠  I'm learning Typescript,React- Redux, Serverless functions, GraphQL
• 🤝  I'm open to collaborating on Projects
• ⚡  I am a Mother Taking Fun Rollercoaster Ride Everyday :)

Skills

Socials

Badges

Top Repositories

hyf-homework's Issues

JS2 Week 2 Feedback

@sowmya1408 ✌️

Warmup array exercises / Doubling of number

Awesome work here 👍

hyf-homework/javascript/javascript2/week2/doubleOddNumber/oddNumber.js

Lines 3 to 8 in cb66912

	const doubleOddNumbers = numbers
	.filter(number => number % 2 !== 0)
	.map(number => {
	const newNumber = number * 2;
	return newNumber;
	});

A minor way I would improve this would be to change the map to .map(number => number * 2. Assigning and returning newNumber is not needed IMO for simple functions like this.

Warmup array exercises / Working with movies

• Exercise 1: ✅
• Exercise 2: The solution for this could be much simpler by doing movies.filter( ... ). Basically it should be very similar to exercise 2.
  

  hyf-homework/javascript/javascript2/week2/workingWithMovies/workingWithMovies.js

  Lines 14 to 25 in cb66912

  	// Create an Array of movie titles with long movie titles
  	const movietitles = [];
  	const allMovieTitles = movies.forEach(movie => movietitles.push(movie.title));
  	const longMovieTitles = movietitles.filter(title => {
  	const allTitles = title.split(' ');
  	if (allTitles.length >= 2) {
  	return title;
  	}
  	});
  	console.log(longMovieTitles);

• Exercise 3: ✅ Nice work
• Exercise 4: ✅ Nice work here as well. Improvements: 1) you could return at the end of the function once instead of having 3 returns. 2) you currently actually modify the movie objects from movies when setting movie.tag. Instead you could copy/clone the object first to avoid that.
  

  hyf-homework/javascript/javascript2/week2/workingWithMovies/workingWithMovies.js

  Lines 32 to 45 in cb66912

  	// create an extra key called tag
  	const extraKeyCalledTag = movies.map(movie => {
  	if (movie.rating >= 7) {
  	movie.tag = `Good`;
  	return movie;
  	} else if (movie.rating >= 4) {
  	movie.tag = `Average`;
  	return movie;
  	} else if (movie.rating < 4) {
  	movie.tag = `Bad`;
  	return movie;
  	}
  	});

• Exercise 5: ✅
• Exercise 6: ✅ Nice work here. The filter function wants a true/false return value so actually you could simplify the last part of the function to return movieTitlesArray.includes('surfer') || movieTitlesArray.includes('alien') || movieTitlesArray.includes('benjamin').
  

  hyf-homework/javascript/javascript2/week2/workingWithMovies/workingWithMovies.js

  Lines 59 to 69 in cb66912

  	const countTotalMoviesForKeywords = movies.filter(movie => {
  	const movieTitlesArray = movie.title.toLowerCase().split(' ');
  	if (
  	movieTitlesArray.includes('surfer') ||
  	movieTitlesArray.includes('alien') ||
  	movieTitlesArray.includes('benjamin')
  	) {
  	return movie;
  	}
  	}).length;
  	console.log(countTotalMoviesForKeywords);

• Exercise 7: Not sure I understand your solution here. duplicatedWordsInATitles is not really used and you don't seem to be returning the movies containing duplicate words in their title.
  

  hyf-homework/javascript/javascript2/week2/workingWithMovies/workingWithMovies.js

  Lines 71 to 76 in cb66912

  	// word in the title duplicated
  	const duplicatedWordsInATitles = [];
  	movies.map(movie => movie.title.split(' '))
  	.forEach(title => title.filter((word, index) => title.indexOf(word) !== index && word !== 'the' && word !== 'The' && word !== 'of' && word !=='and'? duplicatedTitles.push(word) : false));//duplicatedTitles.push(`In title:${title.join(" ")} this word:${word} is duplicated`) : false));
  	console.log(duplicatedWordsInATitles);

hyfBay - get the okay'est products here - continued

Nice work here 💪 Next time remember to remove commented code, it is a bit easier to give feedback that way.