space48/magento2-code-quality

A module that helps to easily apply static code analysers to the project`s code. It uses grumphp under the hood and has predefined set of rules based on Magento 2 coding standards and tuned to be less annoying.

magento2-code-quality's Issues

Add modern Node version support

It looks like the version of ESLint used is outdated and required older versions of Node (version 10 according to https://github.com/Space48/magento2-code-quality/blob/master/script/install.sh#L5)

With the latest version of Node being 16 we should be upgrading ESLint and whatever else is needed to support newer versions.

Possible issue with Warden

Hello,

1. The documentation states :

Note: If using warden, commit still fails with SplFileInfo::openFile(/var/www/html/.git/COMMIT_EDITMSG): failed to open st ream: No such file or directory error: rename or revert to original git 'commit-msg' hook.

Can you confirm that the "commit-msg" hook (installed by GrumPHP) is "redundant", and that's what is meant by this statement ?

2. The documentation also states :

(You can mount .git volume from host to inside container instead, but grumphp only requires empty .git folder, no much sense in syncronizing all .git/* files adding even more overhead for mutagen.)

Have you been trying the tasks git_blacklist and git_commit_message on your installation ? It seems that they both require the .git folder to be synchronized onto the docker container. Otherwise, they'll both fail :

Something went wrong: fatal: not a git repository (or any parent up to mount point /var/www) Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set).

Thanks for your feedback!