spankchain/general-state-channels

Spankchain PoC implementation of generalized state channels

general-state-channels's Issues

Truffle compile and migrate failed.

After forking, truffle compile and truffle migrate returned several warnings and errors. I fixed the critical ones and allowed for Travis CI and Coveralls continuous integration. Some styling changes also.

Several artifacts are also missing from root, so test files cannot pass. I commented out offending blocks to allow for proper build, see here:

NFhbar@1915947

Potential typo in deployCTF?

https://github.com/SpankChain/general-state-channels/blob/master/contracts/ChannelRegistry.sol#L30

In the part of the code that should check the signatures of the bytecode to be deployed, the for loop is initialized at 2 and check if it's less than 2, so the for loop never enters.

Truffle compile successful but migration on Ganache fails

Hi guys, I was looking forward to play with your contracts, so I modified truffle.js file to allow migration to a local Ganache-cli instance running on 8545.
Compilation works OK but migration seems broken.

As a related question, how the project is going in terms of readiness? Are Open/Join/Channel operations already callable in the current implementation?

Thanks.

counterfactual addresses can be made to point to arbitrary code

1. Alice and Bob agree to be bound by a contract C
2. deployCTF is called as part of a dispute with arguments _ctfbytes, _state, v, r, s, where the bytecode of C is included in _ctfbytes as well as _state. This creates a contract with bytecode C at counterfactual address A
3. a third-party attacker calls deployCTF with arguments attackerBytes, _state, v, r, s. Now counterfactual address A points to a contract with code attackerBytes

License information?

Hi all! What is the license that this will be put under?