Solve the assembly issue that unfiltered fails to serve some files

[spark-notebook]

Solve the assembly issue that unfiltered fails to serve some files

[Ludden]

I think that some resources are not included in the assembly. I don't find that assets under spark-notebook\server\src\main\assets\from_ipython are in the assembly jar at all.

[andypetrella]

Mmmmh, okay. Last try I did, the files were in there. Maybe I didn't look at the right place...

So if they're not in the jar, that means that they are shaded in some way. Let's see what's going on then.

Thanks for info man

[Ludden]

Ah sorry, I found the files in the jar now so that's not the problem.

[andypetrella]

Indeed I checked yesterday, they are at the root actually.
In fact, I think it's Netty or Unfiltered that had some problem to deliver
the files.
Maybe updating the version... Need some deeper debug 😯

Le jeu 4 déc. 2014 08:46, Ludden [email protected] a écrit :

Ah sorry, I found the files in the jar now so that's not the problem.

—
Reply to this email directly or view it on GitHub
#39 (comment)
.

[i-am-the-slime]

👍

[andypetrella]

Small update, I'm currently envisioning to migrate everything to Play 2. For several reasons:

• packaging is simpler and works (vs unfiltered)
• the dev lifecycle is shorter (hot changes)

It's not a tiny change, it'll have deep change behind the sea, not easy, but I think it'll be worth.

Is there any objections against this idea?

[Ludden]

Cool, even though unfiltered seems to be a nice library, Play might also be familiar to more people.

[andypetrella]

Yeah!
So it's on its way https://github.com/andypetrella/spark-notebook/tree/play ... I don't sleep much these days :-D

Current status is: spark repl has some hiccups at start time, hence it's not yet functional.
However, the dev lifecycle is so much smooth and pleasant.

I'll keep you posted

[andypetrella]

Okay, I pushed on master a first version of the notebook refactored to use Play. It's functional but not every feature of the notebook have been tested so far (like playing with the kernel f.i.).
However, the examples are working (afaics) and the release is here.