Giter Site home page Giter Site logo

Comments (4)

themsaid avatar themsaid commented on July 2, 2024

Hello :)

Yes please go ahead and open a PR, it sounds cool to me.

from laravel-mail-preview.

coderabbi avatar coderabbi commented on July 2, 2024

Awesome, thanks!

One odd bit of adding this and maintaining BC (obviously need to do that here), is that it would be possible to have mail.preview == false and mail.driver == preview in which case just looking at mail.preview would lead you to believe that they were turned off, but, of course, they would be turned on.

I don't think there's any way to escape that, and I think it's still worth it, but just wanted to note that after I sugested this, I realized it would be introducing a potentially confusing bit, albeit minor.

from laravel-mail-preview.

themsaid avatar themsaid commented on July 2, 2024

I think it's fine if it works if either of the conditions is met.

from laravel-mail-preview.

coderabbi avatar coderabbi commented on July 2, 2024

#29

from laravel-mail-preview.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.