spatie/package-skeleton-php

A skeleton repository for Spatie's PHP Packages

package-skeleton-php's Issues

Username guess in configure.php can result in "undefined array key" warning

When attempting to guess the username, if the remote origin URL is not defined, the configure.php script will throw an "Undefined array key" warning:

https://github.com/spatie/package-skeleton-php/blob/main/configure.php#L90

Since most users are expected to use the repo as a template this may be a wontfix, but thought I would note it.

Use main as the default branch

Moving away from the master / slave terminology I propose choosing a different name for the default branch, such as main.

Typo in configure.php

Firstly, apologies for being too lazy to submit a PR for super minor issues!

Indenting is off on L166 and typo on L167 within the comment (nothign).

configure script: packages with dashes (-) will create invalid PHP code in README usage section

Hello! If I create a package with a - in the package name, the usage section in the README uses the dashes directly for a variable name, resulting in incorrect PHP.

Example: Running the configure script with vendor = Me, package name = my-first-package, class name = MFP results in:

## Usage
```php
$my-first-package = new Me\MPF();

when it should convert the variable name e.g. with slugify to $myfirstpackage.

Thanks for the great video course & this helpful skeleton!