speige/aspnetcore.responsecaching.extensions

aspnetcore.responsecaching.extensions's Issues

Browser sending max-age=0 server-side caching does not cache

Hi all,

I am initialized the middleware like this:

public void ConfigureServices(IServiceCollection services)
        {
            services.Configure<Settings>(Configuration.GetSection("AppSettings"));

            services.Configure<BrotliCompressionProviderOptions>(options =>
            {
                options.Level = CompressionLevel.Fastest;
            });
            services.Configure<GzipCompressionProviderOptions>(options =>
            {
                options.Level = CompressionLevel.Fastest;
            });
            services.AddResponseCompression(options =>
            {
                options.Providers.Add<BrotliCompressionProvider>();
                options.Providers.Add<GzipCompressionProvider>();
                options.EnableForHttps = true;
            });

            services.AddMemoryCache();

            services.AddResponseCaching(ignoreBrowserNoCacheNoStore: true);

            services.AddHttpClient();

            services.AddControllersWithViews();
        }

        // This method gets called by the runtime. Use this method to configure the HTTP request pipeline.
        public void Configure(IApplicationBuilder app, IWebHostEnvironment env)
        {

            app.UseResponseCompression();

            if (env.IsDevelopment())
            {
                app.UseDeveloperExceptionPage();
            }
            else
            {
                app.UseExceptionHandler("/Home/Error");
                // The default HSTS value is 30 days. You may want to change this for production scenarios, see https://aka.ms/aspnetcore-hsts.
                app.UseHsts();
            }
            
            app.UseHttpsRedirection();
            app.UseStaticFiles(new StaticFileOptions
            {
                OnPrepareResponse = ctx =>
                {
                    const int durationInSeconds = 60 * 60 * 24 * 365; //365 days
                    ctx.Context.Response.Headers[HeaderNames.CacheControl] =
                        "public,max-age=" + durationInSeconds;
                }
            });

            app.UseRouting();

            app.UseCustomResponseCaching();
                       
            app.UseEndpoints(endpoints =>
            {
                endpoints.MapControllerRoute(
                    name: "default",
                    pattern: "{controller=Home}/{action=Index}/{id?}");
            });

        }

At the controller action level I put this attribute: [ResponseCache(Duration = 3600)]

When I open the url in chrome by typing it directly on the address bar, it sends max-age=0 header, and that means that the server always generate a new version of the page and never use the cached version.

I have been able to disabled this by adding the line requestMaxAge = TimeSpan.MaxValue; in ResponseCachingPolicyProvider.IsCachedEntryFresh method, just below the line:
HeaderUtilities.TryParseSeconds(requestCacheControlHeaders, CacheControlHeaderValue.MaxAgeString, out requestMaxAge);

But I am sure there is a better way to disable this, in order to send always the server-side cached version of the page.

Thank u!
Best
David

Null Ref Exception CustomResponseCachingMiddleware

Hi all,

First of all, thanks for your effort by creating this package to improve .NET Core native ResponseCache.

I am testing this for one of our new projects in order to apply server-side caching to our web pages. I am getting a null exception error when initializing the response cache like this:

        public void ConfigureServices(IServiceCollection services)
        {
            services.Configure<Settings>(Configuration.GetSection("AppSettings"));

            services.Configure<BrotliCompressionProviderOptions>(options =>
            {
                options.Level = CompressionLevel.Fastest;
            });
            services.Configure<GzipCompressionProviderOptions>(options =>
            {
                options.Level = CompressionLevel.Fastest;
            });
            services.AddResponseCompression(options =>
            {
                options.Providers.Add<BrotliCompressionProvider>();
                options.Providers.Add<GzipCompressionProvider>();
                options.EnableForHttps = true;
            });

            services.AddMemoryCache();

            services.AddResponseCaching(ignoreBrowserNoCacheNoStore: true);

            services.AddHttpClient();

            services.AddControllersWithViews();
        }

        // This method gets called by the runtime. Use this method to configure the HTTP request pipeline.
        public void Configure(IApplicationBuilder app, IWebHostEnvironment env)
        {

            app.UseResponseCompression();

            if (env.IsDevelopment())
            {
                app.UseDeveloperExceptionPage();
            }
            else
            {
                app.UseExceptionHandler("/Home/Error");
                // The default HSTS value is 30 days. You may want to change this for production scenarios, see https://aka.ms/aspnetcore-hsts.
                app.UseHsts();
            }
            
            app.UseHttpsRedirection();
            app.UseStaticFiles(new StaticFileOptions
            {
                OnPrepareResponse = ctx =>
                {
                    const int durationInSeconds = 60 * 60 * 24 * 365; //365 days
                    ctx.Context.Response.Headers[HeaderNames.CacheControl] =
                        "public,max-age=" + durationInSeconds;
                }
            });

            app.UseRouting();

            app.UseCustomResponseCaching();
                       
            app.UseEndpoints(endpoints =>
            {
                endpoints.MapControllerRoute(
                    name: "default",
                    pattern: "{controller=Home}/{action=Index}/{id?}");
            });

        }

Look at the lines services.AddResponseCaching(ignoreBrowserNoCacheNoStore: true); in ConfigureServices and app.UseCustomResponseCaching(); in Configure methods.

With that initialization, I get null exception in the constructor of CustomResponseCachingMiddleware:

public CustomResponseCachingMiddleware(RequestDelegate next, IOptions<ResponseCachingOptions> responseCachingOptions, IOptions<CustomResponseCachingOptions> overridableResponseCachingOptions, ILoggerFactory loggerFactory, IResponseCachingPolicyProvider policyProvider, IResponseCachingKeyProvider keyProvider) : 
base(next, responseCachingOptions, loggerFactory, policyProvider, overridableResponseCachingOptions.Value.ResponseCacheFactory(responseCachingOptions), keyProvider)
    {
    }

The exception is due to overridableResponseCachingOptions.Value.ResponseCacheFactory coming null for this ResponseCache implementation.

I am modified constructor to this:

        public CustomResponseCachingMiddleware(RequestDelegate next,
            IOptions<ResponseCachingOptions> responseCachingOptions,
            IOptions<CustomResponseCachingOptions> overridableResponseCachingOptions,
            ILoggerFactory loggerFactory,
            IResponseCachingPolicyProvider policyProvider,
            IResponseCachingKeyProvider keyProvider,
            IMemoryCache _memoryCache) :
            base(next, responseCachingOptions, loggerFactory, policyProvider,
            GetResponseCache(responseCachingOptions, overridableResponseCachingOptions, _memoryCache),
            keyProvider)
        {
        }

        private static IResponseCache GetResponseCache(IOptions<ResponseCachingOptions> responseCachingOptions,
            IOptions<CustomResponseCachingOptions> overridableResponseCachingOptions, IMemoryCache _memoryCache)
        {

            return overridableResponseCachingOptions.Value.ResponseCacheFactory == null ?
                new MemoryResponseCache(_memoryCache) :
                overridableResponseCachingOptions.Value.ResponseCacheFactory(responseCachingOptions);

        }


    }

So now I check if overridableResponseCachingOptions.Value.ResponseCacheFactorycomes null and then instantiate a new MemoryResponseCache implementation.
But I am sure this is not the correct way to do this, so maybe I am doing something wrong in the initialization and that's the reason overridableResponseCachingOptions.Value.ResponseCacheFactory is coming null.

Maybe anyone could help on this?

Thank you!
Best regards
David