spinnaker/keel

Spinnaker's declarative service

keel's Issues

Event based diff/merge loop

Raise an event to go check resource state vs desired. That way we can trigger the same event on resource upsert for instant action.

Resource deletion

Do we want the ability for users to define a desired state of “this resource MUST NOT exist” and delete it if it ever does?

API: Exportable protobuf API for EC2 plugin

Use SQL rather than Redis

Veto: Execution windows

Cannot include a self-ref ingress rule on a new security group

Actuation fails because the referenced security group does not exist during the operation that is creating it.

Core: Enforce / generate resource names

When a resource is created the metadata/name should be auto-generated using an appropriate mechanism for each resource type that creates a unique name/id.

Deactivate diff/actuation if instance is disabled

Swagger

Separate resource validation / normalization from annealing

Instead of the validate method being part of the ResourceHandler interface we should create a ResourceValidator, allowing multiple to be registered for each resource kind. This has a couple of benefits:

1. Separation of concerns.
2. Ability to include Netflix-specific validation in keel-nflx.

We'll need to ensure all validators for a given resource kind can run in any order.

Refactor: Rename AWS->EC2

Horizontal scaling of diff/actuation

Currently we're using Spring events to trigger diff/actuation of a resource but that ties processing to a single instance. We should:

1. ensure only one instance is triggering diff/actuation of a given resource.
2. allow diff/actuation to be performed on a different instance to the one requesting it.

SQS? Keiko?

Core: Plugin storage engine

Associate artifact versions with environments

Titus: Asset plugin

Fix SQL / SSL

API: Registering assets via REST

REST -> Protobuf -> Keel. This should include defining any gRPC API necessary to get desired asset descriptions from the REST "plugin" to the core application.

EC2: Elastic IPs

Core: health/status endpoints that list registered plugins

EC2: scaling policies

Declarative management of scaling policies.

EC2: clusters / server groups

EC2: Route53

Prevent creation of duplicate resources

If a resource already exists with the name we generate for a new one we should respond with an error.

REST API: List available resource kinds

Prevent duplicate resource checks when > 1 Keel instance

EC2: classic load balancers

Description / convergence of load balancers. Should be at least equivalent functionality to earlier Keel implementation.

EC2: Scheduled actions

Core: Rule processing

Periodic validation of current vs desired asset state and convergence via appropriate plugin.

Core: prevent re-requesting convergence

List detected resource diffs and resulting actions

EC2: Aurora

Don't attempt to anneal if dependent resources don't exist

e.g. security groups referenced by a cluster

EC2: Network load balancers

Cannot upsert security group description

Description is a required field when creating a security group. However the upsertSecurityGroup stage does not allow it to be changed. This can cause Keel to spin forever trying to actuate the desired state.

Maintain a log of detected state changes

Core: Authz for asset registration / updates

EC2: ENIs

Prevent repeated attempts to converge the same diff

There are 2 aspects to this:

1. don't re-converge if the submitted task is still in progress
2. don't keep trying to re-converge a diff when the task fails

Bake a new AMI when a new artifact version is detected

REST API: list resources for an application

Mocking framework

Hi,

hope find you well with this cold call.

I am an author of mocking framework for Kotlin

I see you are using mockito-kotlin.

I just want you to be aware that there is solution that fully supports Kotlin and ask to try it in your new/current projects.

I can help you if you answer to this issue.

Thanks and please star it

When an artifact is registered get latest version from Igor

Veto: Application level enable/disable

Allow disabling / enabling of declarative management on a per-app basis.

Core: Initial architectural changes

EC2: application load balancers

EC2: security groups

Description / convergence of security groups. Should be at least equivalent functionality to earlier Keel implementation.

Removing security group name from a cluster desired state does not delete it

Should red/black the cluster resulting in a new server group without the security group attached.

API: Protobuf APIs for core & asset plugins

Clients need to be able to pull in protos for e.g. Core and EC2 without any Java dependencies (crucially any dependencies of the asset plugins themselves) coming along for the ride.

Core: Asset storage engine

Content-agnostic storage for desired asset state

Core: Version history for asset desired state