spkuehl/chess-clock

Chess clock for adafruit featherboard with circuitpython

chess-clock's Issues

Show colon always when not active player.

Should always look xx:yy when it is paused, currently if stopped on an odd number it will look xxyy.

README: 7 segment display instructions

Link to adafruit 7 segment display instructions.

Add dependency information.

Variable names

b and s are not good variables. I do not know appropriate names.

Initial main while loop took me some time to understand. A comment makes its purpose clear.

I do not know how you start the clock. Looks like its by pressing s button. Could this be dropped if first button starts the clock of other player? That's how I use existing clocks.

Auto-shutoff for idle device.

Code Review

Following comments are about the current code. They do not reflect possible things that might be intended for future development.

Method get_display in CountdownTimer implies return value. It does not. Name should change to reflect no return.

Method get_display has parameter time_left. It is part of self. Method does reference self. time_left. Parameter could be dropped and use self. time_left everywhere.

init parameter: increment=0 may not be appropriate. Can a timer work with zero increment?

Line

chess-clock/code.py

Line 99 in 781a005

time_display = self.get_time_remaining()

sets local variable time_display. It is not used. In IDE check for other unused variables.

In main method, True loop has duplicate code. Design change could reduce duplicate code. Replace player_1 and player_2 with an array and two variables for active and paused index.

Change condition of main game while loop.

Change from while True: to something that checks if the game is over.

Something like: while (player_1.flagged == False and player_2.flagged == False):

Add a pause button to stop both clocks.

Add a pause button (need a new hardware button, could be the discussed in #5) to stop both timers.

To resume the game press the pause button again.

Array for player_1 and player_2

chess-clock/code.py

Line 32 in 06432c6

while True:

Design change could reduce duplicate code. Replace player_1 and player_2 with an array and two variables for active and paused index.

Design a setup/menu system to configure game settings.

When the device boots up the first thing to do is configure and confirm game settings.

• Clock Times (eg. 10 min/player)
• Increment (eg. 5 seconds/move)

Could have 10+5 as the default.

In addition to software enhancements, there will probably need to be an additional button (select) added to the hardware.

Use a decimal instead of colon for < 60 seconds remaining

54.43 not 54:43 to indicate 54 seconds.