spodermenpls/smartquotes

"Smart Quotes" typing converter for Mozilla Thunderbird

smartquotes's Issues

Agree on code style

We need to agree on a code style and we should set up a linter to enforce it.

I use eslint and my preferences can be seen here and here.

duplicate curly & straight quotes appear

Environment:
macOS 10.15.7
Thunderbird 78.11.0

Language:
English

When I type something like — I'm saying "hello" — into a mail message with Smart Quote active on the English setting, it gets transformed into — I’'m saying “"hello”" — with the curly + straight quote appearing at the same time.

Halfway there!

I'm glad someone has taken up this extension!

left double quote is being used where right double quote should be

it looks like the following should be added in compose/rules.js after line 21
if (previous && next && !previous.match(noWordEndRegExp) && !next.match(noWordStartRegExp)){ return return "\u201D"; }

Coding environment

Which coding environment do you use?

I use vscode, web-ext and nodejs.

I think it would be a good idea to have some commonly used scripts (like I have here and here) to streamline the workflow.

Create own website

Should we create an own website? Or can we be part of smartquotes.info?

If we create an own one: where and how should we host?

Agree on a branch/merge/commit schema

We need to have a good git schema so we do not interfere with each other. I'm open to anything.

Two suggestions from me:

1. the main branch is owned by @spodermenpls and only they should change it/merge into it
2. each of us should have an own dev branch

Create settings

I can think about some this that the user might customize.

Here is my not finalized list:

• default rule set
• current smart quote state (active or not)
• shortcut bindings (?)
• custom smart quote rule delimiters (?)

Translation into other languages

Which languages should we support?

I think German and English are given - anything else?

Should we include all quote rules we know of? (A quick search offered this)
Or only German and Englisch? I think French is also commonly used.

"Apply to selection" not working correctly with punctuation marks

If you select the sentence I'm saying "Hello". The last " is not converted.