Comments (5)
Your problem is that you don't let Spring create the AppTomcatConnectorCustomizer
for you. If you leave out that section of the EmbeddedServletContainerCustomizer
it should work, e.g.
@Bean
public EmbeddedServletContainerCustomizer containerCustomizer(){
return new EmbeddedServletContainerCustomizer() {
@Override
public void customize(ConfigurableEmbeddedServletContainerFactory factory) {
factory.addErrorPages(new ErrorPage(HttpStatus.NOT_FOUND, "/error/404.html"));
}
};
}
and the @ComponentScan
will pick up the AppTomcatConnectorCustomizer
.
This is useful stuff though, so thanks for the sample. It will help get the Tomcat piece of #101 together. Anything you can do to show the steps for Jetty will be tremendously helpful too.
from spring-boot.
Thanks Dave. Just getting to a PC. With the section of the EmbeddedServletContainerCustomizer
left out, the AppTomcatConnectorCustomizer
is still never registered. What works though is autowiring it so that spring does the instantiation instead of doing it via new myself.
I pushed the solution that worked for me up. Let me know if I am missing something.
On the jetty front, I'll work up something tomorrow.
Thanks for your help.
from spring-boot.
I'll actually leave this reopened awhile pending Dave's input. If the customizer should be picked up via @ComponentScan
without the EmbeddedServletContainerCustomizer
logic, then appears that is a bug? Can't get it to work without that logic
from spring-boot.
Actually I think the current behaviour is correct. If you think it should work differently you can say why here, but my inclination is to leave it as it is (otherwise we'd end up doing autowiring of all the TomcatEmbeddedServletContainerFactory
extension points, and the same for Jetty).
from spring-boot.
Makes sense Dave. Thanks. That is what I figured, but based on your previous feedback, I thought I might be doing something wrong. The functionality is fine the way it is.
from spring-boot.
Related Issues (20)
- Using Gradle's new file permission API is implemented in a way that prevents removal of the old API
- Support loading config yaml files embedded in env vars via spring.config.import HOT 1
- mapstruct-processor jar is missing when package from springboot2.4 HOT 3
- Reduce warnings reported by Eclipse
- Migrate class references to full javadoc links
- Use javadoc macro for links in adoc files
- Reduce warnings reported by Eclipse
- Rename one instance of DataLdapTestIntegrationTests in spring-boot-test-autoconfigure
- Rename one instance of DataLdapTestIntegrationTests in spring-boot-test-autoconfigure
- Spring Jersey does not return 404 from Controller if entity is null HOT 3
- Some @ControllerEndpoint and @RestControllerEndpoint infrastructure remains undeprecated
- @ConditionalOnProperty for branch of values not match HOT 3
- Update link to documentation for log4j-spring-boot
- Update link to documentation for log4j-spring-boot
- Move "Customize the whitelabel Error Page" how-to
- "Use Spring Data repositories" How-to incorrectly refers to Repository annotations
- Upgrade to Testcontainers 1.20.0 HOT 1
- "Use Spring Data repositories" How-to incorrectly refers to Repository annotations
- "Use Spring Data repositories" How-to incorrectly refers to Repository annotations
- Improve Configuration Experience for Multiple CacheManagers HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from spring-boot.