Comments (5)
Hello, @stepio !
First of all thank you for the interest to the project and your valuable feedback!
And the contribution, of course.
Well, we don't see a big problem to let you write the code as you can with your existing IDE setting and reformat it properly during merge.
Just the problem that we have never thought to have something automatic in the project to let any community contributors just to switch between different settings from project to project.
We fought some time in the past to come up with the same setting between STS (@garyrussell uses it) and IDEA (me). But everything has been done manually, so as we didn't have such a settings config before, we don't have it even right now.
Sorry for the confuse for that eclipse-code-formatter.xml
in the Contribution Guideline, but @garyrussell just said me that he isn't aware about it. So, that part for the setting must be fixed somehow. Here and in the Spring AMQP project as well.
In other places like Spring Integration we point to some setting configs in the Spring Framework project: https://github.com/spring-projects/spring-integration/wiki/Spring-Integration-Framework-Code-Style. But to be honest, they doesn't reflect our formatting requirements anyway. We still need to fix some settings manually.
We can try to find some in our team who is good with the subject, but don't forget that contribution is always welcome. Doesn't matter which one, but that is good to have any of them. Maybe with your contribution we will study anything new 😉
Our apologies for the inconvenience one more time, but as I said above,you feel free to push code as you'd like: we will reformat it on the merge. And yeah... In this case you won't be able to run check
task, because the wrong formatting doesn't meet them.
from spring-kafka.
Hi again!
First of all I've got your idea that formatting is a known issue and that it's not a blocker for PRs, so no complains from my side, just FYI.
I've tried to import Spring formatting rules to IDEA, just to start with something. Used the proposed wiki article from Spring Integration:
https://github.com/spring-projects/spring-integration/wiki/Spring-Integration-Framework-Code-Style
The article refers to the next sets of rules:
https://github.com/spring-projects/spring-framework/tree/master/src/idea
https://github.com/spring-projects/spring-framework/tree/master/src/eclipse
However using IDEA v.14.1.7 (on Mac OS X 10.11.5) I did not manage to import any of them:
- Preferences... -> Editor -> Code Style -> Java
- Here I see the configured set of rules and click "Mange..."
- In the next screen I click "Import..." and don't see the appropriate option to import any of the available file.
Am I doing something wrong? If not, maybe you'll at least share somehow your own config?
from spring-kafka.
Hello, @stepio !
How about to try this way of import that spring-framework.xml
?
from spring-kafka.
Unfortunately such an option is not available in my version:
I use IDEA v.14.1.7 on Mac OS X 10.11.5
from spring-kafka.
Closing due to inactivity; please open a new issue if you are still having problems.
from spring-kafka.
Related Issues (20)
- KafkaTemplate currentSpan tagging issue HOT 1
- Creation of `kafkaJaasInitializer` bean fails in a read-only filesystem due to creation of temporary file HOT 3
- Creation of `kafkaJaasInitializer` bean fails in a read-only filesystem due to creation of temporary file HOT 1
- Embedded Kafka throws NoSuchFileException HOT 7
- Implement CommonErrorHandler.handleOne() in CommonDelegatingErrorHandler HOT 1
- Implement CommonErrorHandler.handleOne() in CommonDelegatingErrorHandler HOT 1
- Implement CommonErrorHandler.handleOne() in CommonDelegatingErrorHandler HOT 1
- Switch `EmbeddedKafaka#kraft` default to `false`
- Pause a consumer for X minutes HOT 4
- Documentation for configuring custom `ConsumerFactory` and `ProducerFactory` beans when using Spring Boot is incorrect
- Documentation for configuring custom `ConsumerFactory` and `ProducerFactory` beans when using Spring Boot is incorrect HOT 1
- Add group.protocol property to ConsumerProperties
- Authorization via keyTab file in Windows (absolute windows file path) HOT 5
- Spring Boot with Kafka Template with supplied tags provider breaks spring_kafka_template metric HOT 6
- @RetryableTopic not working for asynchronous @KafkaListener return types HOT 4
- On kotlin application, Spring kafka 3.2.0 doesn't take the message conversion logic, because of the wrong coroutine detection on MessagingMessageListenerAdapter HOT 2
- Add tracing headers to be mapped to string HOT 1
- Add tracing headers to be mapped to string HOT 1
- On kotlin application, Spring kafka 3.2.0 doesn't take the message conversion logic, because of the wrong coroutine detection on MessagingMessageListenerAdapter HOT 1
- Possible inconsistency in DLT topic naming convention
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from spring-kafka.