sskodje/gifimagesource

GifImageSource is a Windows Runtime Component for WinRT projects, made for rendering GIF images in a resource efficient way using Direct2D.

gifimagesource's Issues

Not handling URIs with a query in the path

I noticed an issue where some URLs were throwing an exception with the message The filename, directory name, or volume label syntax is incorrect. After a little debugging this was happening with URIs that had a query after their extension.

It looks like the GetFileExtension function doesn't expect the query, so it returns a file extension with the query in it, e.g. .gif?w=200. Because the filename then illegal file path characters, the exception occurs when trying to save to the cache.

To Reproduce:

Just create an image and try to set an image URI with a query in the path, e.g.:

<Image gif:AnimationBehavior.ImageUriSource="https://uploads.disquscdn.com/images/c6aed8d2d4ba77c60eee3f761004fc879c8ad0727419a7dd566081a8dad2fb34.gif?w=200" />

It's easy enough to strip the query from the path before setting it, but there might be cases where that changes the resource (size, quality, etc.). It wouldn't necessarily be ideal to save the resource while ignoring the query either, so the best solution could use some discussion.

Multi-View UWP app crashing

It seems that there is an issue with 'multi-view' style UWP. In multi-view style, the app have multi window page, and each window page running with their own thread.
I've put the recreation sample to my onedrive.
http://1drv.ms/1TcJw5l
This sample is based on Microsoft UWP sample 'Multiple Views'. I've add the animated-gif image control to both main and secondary views.
https://github.com/Microsoft/Windows-universal-samples/tree/master/Samples/MultipleViews

Here is a recreating procedure:

1. Start the App.
2. Click the button 'Create new view'.
3. Select the 'New View' from listbox 'Open views'.
4. Click the button 'Show selected view as standalone'.
5. Secondary view page appears. You can see the animated gif image.
6. Close the secondary page. The focus is backed to the main page, then the app halted and crashed.

Mobile-only: Unknown crashes based on app visibility

Hi, I use your nice library to show some local GIF files. Works very well and light, even on mobile. Trouble is as soon as the app visibility goes down, I get a crash with no exception. No crash happens if I remove the GIF view, nor does it crash on desktop/tablet.

Best error message I was able to coax out was "WinRT originate error".

Few issues

There are 2 issues and maybe a feature request. The first one causes a hard crash and gives me either "processes is being used by another process" or similar with "access denied"

The second issue only happens in debugging with native code enabled.

The feature request would be an event trigger for when the gif or image finishes loading.

See this video to understand better https://onedrive.live.com/redir?resid=A9B13DE7E292CEE0!1013929&authkey=!AIk36ZAwbISLig8&ithint=video%2cmp4

Memory leak maybe.

I ran into another issue and probably the last one ill have. I have noticed that my ram and cpu will skyrocket as i load more gifs even if it's the same gif. ill explain in the video.

https://1drv.ms/v/s!AuDOkuLnPbGpwPRYC0HpDSl0bGUP5Q