staaky/strip

Strip - An Unobtrusive Responsive Lightbox

strip's Issues

Cannot use caption for group

Strip.show(['image1.jpg', 'image2.jpg'], {
loop: false,
maxWidth: 500,
caption:'A Caption'
});

100% page height not covered

Please see live demo here: http://rohitkhanvilkr.zz.mu/rkf.html
Click on the last image in the list to open top sliding lightbox. We expect it to occupy full height, but keeps some margin down.
OS is Windows 8.1, Browser Chrome 43.0.23.
Screen shot attached.

Dynamically changing strip-group causes weird behavior.

If you want to dynamically change data-strip-group Strip has some unusual behavior.

Usecase:

I have 50 photos, that need to be in a group all onload.
User input can filter photos to a new category, which also changes the data-strip-group.

When users first click on a photo in the all group, it sorts them nice in a 50 photo group. But when clicking strip away, navigating to a new category (thus changing the strip-group attribute), and clicking a new photo that now belongs to a different strip-group, Strip removes the photos of the new group from the all group, and shows the all group instead.

When immediately filtering to a category, repeating the steps above but avoiding the "all" category, it works just fine.

Code used to change attribute:

$(function(){
    $('.photos-container').isotope({
        itemSelector: '.photo',
        layoutMode: 'masonry'
    });
   
    $('.photo-navigation .iso-nav-btn').on('click', function(){
        filter = $(this).data('category');
        $('.photos-container').isotope({
            filter: filter
        });
        
        if(filter === "*"){
            $('.photo .strip').attr('data-strip-group', 'all');
        }else{
            $(filter).find('.strip').attr('data-strip-group', filter.substr(1));
        }
    });
});

I'm guessing it has something to do with the eventlistener attached to the photo elements, but I can't find a way to destroy and reattach the listiners on each filter.

`onShown` fired when resizing

The document states onShow: A function to call when Strip comes into view. According to my test, it also fires when resizing.

An event only fires once is wanted.

readme screenshot

NPM foldername has illegal characters

Hi.

Your npm name has illegal characters.
The @ in the name is not allowed and is not executable on a CI Server.

There should be a bower package for this!

Strip with text?

HI,

I need some help, is it possible to use strip but to display text instead of an image/video?
I love the dropdown from top but i need it to display text not an image and ive tried and failed :/

Is there a way? Ive read the documentation and i cant see the answer there.

Thanks in advance and good work!

hide() throw exception when strip is closed already

Unless there's a method to test if Strip is closed (or shown), hide() should not throw exception when closed already.

null is not an object (evaluating 'this.view.options')

From https://github.com/staaky/strip/blob/master/src/js/window.js#L430

Vimeo options issue

data-strip-options="vimeo: { autoplay: 1, title: 0, byline: 0, portrait: 1, loop: 0 }

Adding options to a Vimeo video works only the second time I click the element with the strip class. Same behaviour is happening on the Strip vimeo sample on your website.

It seems that the iframe is being created the first time I clicked the trigger and the second time is actually reading the options.

.....

Update: it is happening just in MacOS using Chrome. The same doesn't happen on Firefox or Safari, neither using Chrome on Windows.

Safari: hidden/flickering box on vimeo video on 2nd click

Just discovered that the Vimeo box get's hidden after the 2nd foldout:

Demo: http://youtu.be/_AoR14F9BrY

• Refresh the site
• click on the Vimeo video
• click anywhere on the screen (the video box hides)
• reclick on the Vimeo video

discovered on the projects home page with Safari Version 7.1 (9537.85.10.17.1)

Uncaught SyntaxError: Unexpected end of input

woah, i'm hungry,
sorry,
i found some error in console Uncaught SyntaxError: Unexpected end of input in strip.pkgd.min.js:82.
Any idea what may is?
Tips: The files strip.pkgd.js is working fine.
Saludos!

Licensing is invalid and strongly misleading

"For non-commercial, personal, or open source projects and applications, you may use Strip under the terms of the GPL v3 License." You cannot release something under the GPL for non-commercial use only. That is an invalid additional restriction which the GPL forbids - the sentence pretty much contradicts itself. This means you either just revoked the GPL in the very sentence you granted it, making everyone legally unable to use your product without a commercial license, or you just granted everyone the right to use it commercially as well - whatever the lawyers make of it. Anyway, you should really fix this.

Adding Markup to Content

Hi,
I am trying to add a deep-link and sharing buttons to a strip lightbox. I have got the deep-link sorted out by adding some code to the onShow callback, but I am running into a wall for the sharing buttons. Let's say I want to insert the buttons into the strp-info section. Obviously, since sharing is involved, I need to dynamically pass the page URL (not the image URL) and title information. What would be the easy / right way to do this? If I try to print this in the onShow callback, I am getting the Strip object. Is there a way to reference the UI element inside?

set default options

Is there a way to globally override the default options?

If I understand the code right, the only way to override the defaults is by setting them on a per image/show basis.

It would be nice to be able to say for example "always show the image from the left side, except if defined otherwise"