Comments (4)
Yeah, this is a good idea. Maybe another option could be to use Object.toString() or perhaps we could add a test to skip that whole conditional if HTMLCanvasElement etc. are not defined in the current environment?
from gl-texture2d.
It's not pretty but this would work without changing the existing behaviour at all:
if (('undefined' != typeof HTMLCanvasElement && obj instanceof HTMLCanvasElement) ||
('undefined' != typeof HTMLImageElement && obj instanceof HTMLImageElement) ||
('undefined' != typeof HTMLVideoElement && obj instanceof HTMLVideoElement) ||
('undefined' != typeof ImageData && obj instanceof ImageData)) {
from gl-texture2d.
also @vorg, see my thoughts on text rendering here. Feel free to add any thoughts:
stackgl/contributing#26
from gl-texture2d.
I've provided a PR that implement @hughsk suggested solution.
from gl-texture2d.
Related Issues (7)
- typedarray-pool dependency is outdated HOT 1
- `tex.setPixels` binds to unit zero HOT 1
- usage with node-sharp HOT 4
- HTML5 video HOT 1
- Texture Is Sideways HOT 4
- Simple array upload? HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from gl-texture2d.