stamusnetworks/suricata-language-server

Suricata Language Server is an implementation of the Language Server Protocol for Suricata signatures. It adds syntax check, hints and auto-completion to your preferred editor once it is configured.

suricata-language-server's Issues

Display rules that don't have fast pattern

In some case, we can have a rule without fast pattern (but with mpm). We should warn in this case on performance issue.

Better handling of multi line signatures

We are missing some warnings with rules that are spread over multiple lines with '\'.

There is also a problem with completion.

Use github actions to build packages

We can use Github Actions to build the packages for the Python server and the VSCode extension.

Windows 10, VSCode, not enough values to unpack error in latest release with UNC path

Hi Eric,

Works great in Linux, however running into this error in Windows 10, VSCode below when using a UNC path (ie \server\share\rule.rules). From what I can tell, I think it's an issue with jsonrpc specifically (I can put in an issue over there if that makes sense to you).

I will put a PR in shortly to note this in the README.

Basically, any UNC paths get treated as file:///server/share/rule.rules.

The workaround is to use a mapped drive letter reference to open the file (or folder with rules in it). X:\Rules\rule.rules, instead of the UNC path. This works as expected.

Screenshot:

Traceback:
Traceback (most recent call last): File "C:\Python310\lib\site-packages\suricatals\langserver.py", line 99, in handle handler(request) File "C:\Python310\lib\site-packages\suricatals\langserver.py", line 322, in serve_onSave filepath = path_from_uri(uri) File "C:\Python310\lib\site-packages\suricatals\jsonrpc.py", line 24, in path_from_uri _, path = uri.split("file:///", 1) ValueError: not enough values to unpack (expected 2, got 1)

VSCode - Highlighting Problem

I have an installation of VS Code

Version: 1.87.2
Commit: 863d2581ecda6849923a2118d93a088b0745d9d6
Date: 2024-03-08T15:14:59.643Z
Electron: 27.3.2
ElectronBuildId: 26836302
Chromium: 118.0.5993.159
Node.js: 18.17.1
V8: 11.8.172.18-electron.0
OS: Linux x64 6.7.9-100.fc38.x86_64

Everything of Suricata completion and suggestions works except highlighting. It detects that the file is Suricata file. In other languages, highlighting it works just fine.

Do you know how I can fix it?
Thanks in advance.