starknet-io/starkgate-contracts

starkgate-contracts's Issues

P.M.'s feedback

Tried both USDC and ETH. USDC transaction pop-up said you can track on the right, and I was able to dismiss the popup. For ETH, you can see the pop-up in above screenshot. There is nothing I can do on the page now. The pop-up doesn't go away, and there is no progress pop-up on right side for ETH. Things need to be consistent irrespective of the asset.

Typo in `StarknetBridgeConstatns`

It should be StarknetBridgeConstants

Transaction has been reverted by the EVM

Transaction has been reverted by the EVM:
{
"blockHash": "0xdac6f81f5aedfc9fd56163206a79cf2b918a967d07fff759807d45c17ee14532",
"blockNumber": 14842309,
"contractAddress": null,
"cumulativeGasUsed": 12778168,
"effectiveGasPrice": 36630331912,
"from": "0xed0bd7f319cd03539cbd3b5c592cae91a349dbae",
"gasUsed": 29623,
"logsBloom": "0x00000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000",
"status": false,
"to": "0xae0ee0a63a2ce6baeeffe56e7714fb4efe48d419",
"transactionHash": "0xa7d163100faaea48c7e9f76b71c2c383bf46e9112a42259e5999c732e0d98695",
"transactionIndex": 259,
"type": "0x2",
"events": {}
}:
{
"blockHash": "0xdac6f81f5aedfc9fd56163206a79cf2b918a967d07fff759807d45c17ee14532",
"blockNumber": 14842309,
"contractAddress": null,
"cumulativeGasUsed": 12778168,
"effectiveGasPrice": 36630331912,
"from": "0xed0bd7f319cd03539cbd3b5c592cae91a349dbae",
"gasUsed": 29623,
"logsBloom": "0x00000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000",
"status": false,
"to": "0xae0ee0a63a2ce6baeeffe56e7714fb4efe48d419",
"transactionHash": "0xa7d163100faaea48c7e9f76b71c2c383bf46e9112a42259e5999c732e0d98695",
"transactionIndex": 259,
"type": "0x2",
"events": {}
}

T.O.'s feedback

. Was not connected to Goerli, got the message “Network not supported” but would be better for the website to ask MM to connect to the correct network 😄
2. I think a disclaimer on how long the transfer is expected to last would be great. Currently I got two chrome notification (“metamask transaction confirmed” and “message correctly sent to l2”) but not I’ve got the “Transfer in Progress” without any idea on how much I’m expected to wait (5min? 7 hours?). I imagine a progress bar would be inaccurate, but at least giving a rough idea on how long the transfer is expected to take would be nice.
3. In the same idea, maybe having a clickable button “Have any question? Come ask us!” or “Can’t find your transaction? Contact us!”. Basically somewhere where we can ask questions 😄
4. Just a note: really funny to have both MM and Argent addresses working together on the same page. I like it! Though I’m sure some people will get lost with it haha
. I got a note saying “You can follow the progress on l2 on the right side notification” but the notification popped when my tx was already accepted on l2 I think ^^
6. Even after having my tx accepted on l2, I still have a “pending” available balance. I’m guessing something is down at this point because it’s been loading for a couple of minutes ^^
20:05

Ooooh ok nvm, nothing is down:
7. The available balance goes “pending” (not pending but circle animation) for quite a long time, and then briefly displays “1 ETH” (which is the correct amount) for 5 seconds. It then tries to update again, and goes back to displaying the circle animation. I believe a better scenario here would be to display the “loading” circle once at startup, and then maybe try to update in the background WITHOUT changing the displayed available balance until a value has been returned 😄

8. Ideally I’d be able to click the “max balance” of ETH I want to send and it would substract the tx fees from the amount. This would allow the user to basically send the max balance and leave him with 0 ETH on his account 🙂 Right now when I click max, it just inputs the max amount and then MM tells me I don’t have enough funds 😄

9. Bridging back from l2 to l1 is extremely slow 🙂 Took 1 min for Argent X to broadcast my tx, and then another minute for my tx to get accepted on L2 🙂

10. Typos in the “Transaction sent” pop up: is now being processing on L2 / we will promote you to complete your transfer (I don’t think promote is correct in this situtation but not 100% tbh :p)

11. Same as point 5, this pop up pops when the tx has been accepted, so telling me “you can track the progress on the right side of the webpage” make little sense to me 😄

12. On this same pop up, a link is given to view my tx on Voyager but it looks like it’s broken: https://goerli.voyager.online/tx/0x5173be5a66fb050f0ba36b0c92cac469b1b8103caaa729bbbcc14d45a0f7c8 . It is my understand that I will be able to see it once it’s properly accepted, but I just believe it might be confusing to tell users “have a look here” if it sends to something not yet accepted (and with nothing to track status :D)

Airdrop allocation

Hey there,

I wanted to bring to your attention an issue that was raised back in February on the provisions-data GitHub page. It pertains to users who have met the airdrop criteria but haven't received anything. Despite my efforts to communicate this to the developers, I was inexplicably banned from Discord some time ago. Undeterred, I'm reaching out here in hopes of raising awareness, as it appears this matter has been overlooked.

Within my post, you'll find accounts from several individuals affected by this issue.

Best regards,
Mathias

idk if it is possible but

Idk why I haven't seen this feature I guess anywhere... but it would be nice if the contract would automatically deduct the amount of gas from transaction. For example I press the max button and of course I won't have enough eth to pay for the gas. So what's the point in this button then etc.
Thank you
feel free to send me some rewards lol:)
0xBF8E981e8D048360db023035428EA8A22Cd169eB

Update Readme file to include new docs

Change the links in the README.md to new links from new docs:
https://docs.starknet.io/documentation/architecture_and_concepts/Network_Architecture/token-bridge/