steeeephen/lava

LoL Automated Video Analytics: Open-Source VoD Analytics Tool for League of Legends

lava's Issues

Refactor codebase to abstract away functionality from lava.py into separate modules

Currently, almost all logic is in the lava.py module. This makes the code hard to maintain and difficult to manage. This also makes the code impossible to unit test, which should be something done in the future. Logic should be abstracted into separate folders and made into python modules by adding an init.py file. See: https://packaging.python.org/en/latest/guides/packaging-namespace-packages/

Fix proximity graphs

Proximity graphs have the lines above the champions. Plotly doesn't allow for such specific layering (minimap > shapes > portraits) so will have to find a workaround

Double check role positions using champion and positions

Right now the tool assumes the players line up from top to support, but that may not always be the case. Use a simple classification model to predict which role each player actually played based on their locations in the first 15 minutes and champions

Indentation

Hi! I'm wondering if we could change the global styling to match PEP-8 guidelines with four spaces of indentation.

`upkeep_scripts` not easily approachable in new version

Some of the scripts in upkeep_scripts are outdated and others should be moved into the web app for easier use

Champ portraits in lvl1 graphs

Seems like the champ portraits in level 1 graphs don't match up with the graphs themselves

Champ portraits in level 1 graphs bugged

Seems like the champion portraits in the level one graphs don't necessarily match up to the correct champs

Noted and shouldn't be a big fix

Unintuitive input format

Currently the input format for local videos makes no fucking sense

• Add video to input/ folder
• Specify the path within the input/ folder (not the full filename)
• LAVA takes the path and uses that for the output filename

This is a symptom of postgrad me being an idiot code-wise, will fix it to just use the full path

Broadcast-specific overlay issues

LAVA can sometimes struggle to automatically figure out the league, would be worth investigating if it's a common issue and whether I should reintroduce the concept of choosing the league before running the program

Lightweight mode timer issue

Lightweight mode just uses the old logic of 'read the timer from the baron timer' but without stopping at 20 minutes. It should be reintroduced as otherwise the timer data is messed up

Investigate using poetry to manage packages

While currently a low priority issue, in the future with Docker deployments, we should manage the library versions used in this repo.

Fix Timer

The timer wasn't being read properly as it was too small

Fix Viego positions

viego changes his ingame portrait when he transforms, try to avoid this messing up the data