steffenpl/boundeddegreegraphs.jl

Allocation free graph implementation for sparse graphs with bounded degree.

boundeddegreegraphs.jl's Issues

TagBot trigger issue

This issue is used to trigger TagBot; feel free to unsubscribe.

If you haven't already, you should update your TagBot.yml to include issue comment triggers.
Please see this post on Discourse for instructions and more details.

If you'd like for me to do this for you, comment TagBot fix on this issue.
I'll open a PR within a few hours, please be patient!

Random remarks

Hey there @SteffenPL,

Taking a very quick look at your code, here are a few things I thought of. We can always structure them later.

• I would separate the various structs into different files to make it clearer which methods belong to which
• Why do you need a new edge type?
• Assertions can be deactivated, better to throw errors for invalid inputs
• Is edge addition type-stable? I'm not sure what the callbacks are for but they could lead to performance issues (see the infamous https://docs.julialang.org/en/v1/manual/performance-tips/#man-performance-captured)

Use `Set` instead of `SparseBitList`

Seems like the SparseBitList type which I made for this package is redundant. Using the Base.Set and a sizehint! is probably better in every aspect.

I will change it to Set and remove SparseBitList entirely.

---

One the other hand, lookup in Vector is faster for small sets: https://bkamins.github.io/julialang/2022/04/08/fast2.html

Register

@JuliaRegistrator register

Naming of the package

Maybe BoundedDegreeGraphs is misleading, as it could also be seen as a uniformly sparse graph?
(However, uniformly sparse graphs could also refer to graphs with are not sparse in terms of the degree but only bevause ev() / nv()^2 is small...)