steinbergmedia/vst3_base

vst3_base's Issues

Where did fthread.h go? What new file should I use?

Hello,

I was just wondering where thread/include/fthread.h got moved to or changed to? I am trying to rebuild the openglviewtest example from VSTGUI and fthread.h appears to be missing. I read somewhere the file was moved to thread/include/flock.h, but there are still some things missing in Base::Thread::FThread like virtual uint32 entry(). Where can I find the new FThread class, or what should I be using in the newer SDK?

Edit: I found there is a class called FCondition in thread/include/fcondition.h which allows me to set a timeout for the thread using FCondition::waitTimeout(int32 milliseconds). Then I guess I can run the OpenGL draw call and the timeout in a while loop like the original openglviewtest.cpp file does. Hopefully I am going in the right direction.

Reference counter race condition

Hi, I believe there may exist a race condition at FObject::release. (as of 3.7.1)

At function's end, the refCount is reloaded a second time, after the atomic decrementation.
One could provide a slightly different implementation to prevent this.

	int32 newCount = FUnknownPrivate::atomicAdd (refCount, -1);
	if (newCount == 0)
	{
		refCount = -1000;
		delete this;
		return 0;
	}       
	return newCount;

---

Taking the original implementation as a reference, I imagine we can met a following problem scenario:

(1)	if (FUnknownPrivate::atomicAdd (refCount, -1) == 0)
	{
		refCount = -1000;
		delete this;
(2)		return 0;
	}
(3)	return refCount;

• T1 executes the atomic decrementation at (1)
• T2 executes the atomic decrementation at (1), and proceeds to (2), deleting the object
• T1 loads at (3) from the deleted object and crashes

"Windows.h" breaks MinGW on case-sensitive filesystems

On Linux this works fine:
#include <windows.h>
but not this:
#include <Windows.h>