steipete/psmenuitem

A block based UIMenuItem subclass.

psmenuitem's Issues

dynamic add selector

no need to swizzle any func, very easy

struct Info {
      var id = ""
      var title: String?
      var callback:(() -> Swift.Void)?
}

func menuItems(infos: [Info], targetClasses: [AnyClass]) -> [UIMenuItem]  {
        var items = [UIMenuItem]()
        infos.forEach { (info) in
            // dynamic add selector for custom selector
            let aSelector = NSSelectorFromString("custom_prefix" + info.id)
            let block = { () -> Swift.Void in
                info.callback?()
            }
            let castedBlock: AnyObject = unsafeBitCast(block as @convention(block) () -> Swift.Void, to: AnyObject.self)
            let imp = imp_implementationWithBlock(castedBlock)
            targetClasses.forEach({ (targetClass) in
                if class_addMethod(targetClass,
                                   aSelector,
                                   imp,
                                   UnsafeMutablePointer(mutating: "v")) {
                } else {
                    class_replaceMethod(targetClass,
                                        aSelector,
                                        imp,
                                        UnsafeMutablePointer(mutating: "v"))
                }
            })
            // create item
            let item = UIMenuItem(title: info.title ?? "", action: aSelector)
            items.append(item)
        }
        return items
    }

have mistake

i run your demo but have some mistake

Warnings using PSMenuItem in iOS 8

I get the following warnings in iOS 8:

~/src/PSMenuItem/PSMenuItem.m:80:40: Undeclared selector 'pspdf_canPerformAction:withSender:'
~/src/PSMenuItem/PSMenuItem.m:85:43: Undeclared selector 'pspdf_canBecomeFirstResponder'
~/src/PSMenuItem/PSMenuItem.m:100:43: Undeclared selector 'pspdf_methodSignatureForSelector:'
~/src/PSMenuItem/PSMenuItem.m:111:45: Undeclared selector 'pspdf_forwardInvocation:'

Project no longer compiles by default on iOS8

Hello! The project no longer compiles by default no iOS8.

Here are some changes I did to make it compile:

((void(*)(id, SEL, NSInvocation*))objc_msgSend)(_self, forwardInvocationSEL, invocation);

return ((NSMethodSignature *(*)(id, SEL, SEL))objc_msgSend)(_self, methodSignatureSEL, selector);

After getting it to compile, it still doesn't seem to work. The UIMenuController would still ask the active UIViewController for canPerformAction:sender: and canBecomeFirstResponder:.
(I did remember to install the handler)

Problem when using with PSPDFKit

If you're using this library while also using PSPDFKit you'll get duplicate symbol errors regarding kMenuItemTrailer - renaming to kMenuItemTrailerPSMenuItem fixed the linking errors.