stellar/actions

GitHub Actions for Stellar repositories.

actions's Issues

Rust Release Workflows: Release from a branch for patch releases.

We should modify the existing rust release bump version workflow so that it supports releasing crates from a branch that isn't the main branch.

The use case for this is so that we can create a branch for a minor or patch release separately to the main branch. We might want to do that if we have already committed new features or breaking changes to the main branch but then later plan to release a non-breaking or bug-fix-only release.

The changes to support this are minimal:

• 🏆 Add a branch input to the rust-bump-version workflow that defaults to main.
• 💎 Change the rust-bump-version workflow not always create a new branch, but modify an existing branch if one exists.
• 💎 Change the rust-bump-version workflow to skip creating the PR if one already exists for the release branch.
• 🏆 Include instructions in the pull request description created by the rust-bump-version workflow that explain how to complete non-main branch releases.
• 🏆 Include instructions in the release docs.
• 💎 Make it clearer when publish-dry-run is in a good state.
• 💎 Make it about what the process should be for patches and regular releases.

The tasks to perform are categorized as:

• 🏆 Completion – This change is required.
• 💎 Polish – This change would be beneficial, but we could get by without it.

Add action that verifies Rust git dependency commits will not be orphaned

What

Add action that checks git rev deps for whether they are likely to be orphaned.

Why

On a number of occassions we've accidentally committed a reference to a dependency that belongs to a commit on a pull request. The pull request was then closed, and while the commit lives forever in the Git repository, it is not seen by tools that do not fetch orphaned commits.

rust-cache doesn't seem to work on non-linux hosts

See all the Build jobs at: https://github.com/stellar/soroban-rpc/actions/runs/9584445833/job/26428082692

The make build-preflight step (which builds the libpreflight Rust library) is really fast on Linux (both amd64 and arm64) where it takes less than 30 seconds.

On MacOS and Windows it takes around 2 minutes, which makes me think that caching is not working.

Tentatively marking as a bug.

Make rust-publish-dry-run run builds and tests on all supported OSes of the project

Make rust-cache work on all GitHub Runner OSes

The cache action doesn't work on windows or macOS because it relies on sha256sum which isn't installed on mac, and the commands don't work on windows.

Make rust-publish also publish binaries for projects with publish=true binaries