Giter Site home page Giter Site logo

Comments (4)

Stephane-D avatar Stephane-D commented on July 21, 2024

That change was basically made for better stdint compatibility O_o, see this issue : #45
The #if !defined(uint8_t) && !defined(__int8_t_defined) portion should avoid the conflict no ?
So it looks that pull request is not safe if you want to use the standard stdint include ?

from sgdk.

doragasu avatar doragasu commented on July 21, 2024

Hum... I'm using SGDK on Linux built by the script by Kubilis. I built the toolchain 2 days ago, maybe the script didn't build the latest git version. I'll check if that code is present inside types.h

from sgdk.

doragasu avatar doragasu commented on July 21, 2024

I have checked and the code is there. Once I saw the code, I immediately understood that this workaround only works if you make sure you include stdint.h before sgdk related stuff.

I reversed the include order and can confirm that now it builds without problems.

I'm closing the issue, but I suppose it would be better including stdint.h inside SGDK, instead of redefining the types, to avoid these problems.

Thanks for the support!

from sgdk.

Stephane-D avatar Stephane-D commented on July 21, 2024

You're welcome :)

from sgdk.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.