steve0xp/passive-gearbox-strategy-v2yvault

Passive gearbox strategy for yearn v2 vaults

Welcome!

🙋🏻‍♂️ About Me :

• 🔭 I’m a smart contract dev / dev rel currently with over three years of experience in DeFi full-time. I am currently working full-time on a number of projects (using different github accounts :)). That said, I am always open to meeting more people in the industry so please feel free to reach out to chat! Please inquire for my formal resume :), otherwise here's some details about some of my work / me!
• 🌱 As well, I contributed / contribute to open-source DeFi projects including:
  • Smart Contract Work (Solidity): Yearn strategies && general oracle design
  • Technical Writing: technical threads for Yearn, Balancer, DAO tooling, Subgraphs, && NFTs
  • Developer Advocacy: beginner tutorials & more advanced tutorials about integrating into actual DeFi protocols for BUIDL GUIDL
    • Most recent work is focused on finishing the Scaffold-ETH-DeFi-Challenge-2 revolving around ERC4626 Adaptors with Sommelier and Aura Protocol as an example. I am also working with a handful of other developers on Custom Balancer pool content for Scaffold-Balancer.
• 👨🏻‍💻 Recent public work: Serve as a Balancer Grants Committee member, co-hosted a hackerhouse at EthDenver 2023 with Jessy's Hackerhouse && BUIDL GUIDL, core contributor to Photon, a decentralized stablecoin protocol (see pinned repos && CV Details below for highlights)
• ⚡ Fun facts: I've hitch hiked in Iceland, and was CTO of a hockey equipment startup in the NHL (but can't stop on skates 🤷🏻‍♂️)

---

📜 CV - (newest to oldest, if no README see description)

1. April 2023 - Present: Defi Smart Contracts Contributor && Dev Rel w/ numerous projects

2. January 2023 - April 2023: Yearn Mellow-Gearbox_wETH Strategy

3. January 2023 - Present: Standardized Oracle System - in private repo currently.

• Draft Thread: https://typefully.com/t/yNLqP7A
• Figma: https://www.figma.com/file/cJnuNMpZaU7qto39P8NxR2/Today%27s-Oracle-Design-Flow-Chart-v1?node-id=0%3A1&t=0I5QbBWpBvaO4G6M-1

4. March 2022 - January 2023: Ekonomia Technologies core contributions to Photon Finance Protocol - Smart Contract Development && Partnerships Integration (see architecture schematic & whitepaper here for reference. Highlighted PRs below showcase my past experience in conceptual design, implementation, reviewing, && testing for various contracts:

   • ModuleManager.sol :
     • The Module Manager acted as the intermediary between the Modules and the Kernel.
   • *Genesis TWAP Oracle for stablecoin, governance token, and possibly other modules :
     • Oracle exposed USD/PHO price using v1 Curve PHO/FraxBP Metapool TWAP Pair Oracle && USD PriceFeeds (USD/FRAX && USD/USDC). Initial design was an oracle aggregator w/ built in contingencies for a modular oracle system to be used throughout protocol. It was simplified to carry out an iterative design process.
   • PIDController.sol, Pool.sol, Share.sol inspired from Frax && wrote foundry tests mainly for PIDController.t.sol :
     • Developed the initial conceptual designs of a PID Controller within stablecoin mechanism design for peg control similar to FRAX foundational tech.
   • Liquity Subgraph for Reputation Scoring :
     • Created and deployed the first iteration of the liquity subgraph that follows the "Lending Subgraph Standard" schema. It was meant to be used for a potential reputation scoring system within early iterations of Photon protocol where lending and borrowing rates would differ based on on-chain reputation scores from accrued & ongoing on-chain activity.

5. March 2022 - Pak Subgraph : Implemented my first subgraph whilst thinking about perspective & use cases of end-user.

6. January 2022 - Present BUIDL GUIDL Contributor

*TWAP implementation found not suitable for curve, so implemented other corrections. Spun out to now deeper understanding && research for a generic oracle setup for all protocols to use.

passive-gearbox-strategy-v2yvault's Issues

Simulation of partial liquidity upon withdrawal

Context from chat w/ 0xValJohn:

Repo [link](https://github.com/0xValJohn/foundry_strategy_mix/blob/76e1feb53121e78c4a15cb00394aba42be7abd9b/src/Strategy.sol#L178)
Extra Notes:
A simulation of partial liquidity upon withdrawal. I need to simulate (prank via foundry) burn dieselToken: here

Investigating setting up this test and why it is needed:

• Look at the testStrategyLimitedLiquidityNoLoss() unit test from 0xValJohn.
  • Outline scope of the unit test (partial withdraw because of certain edge case - liquidity not available for some reason in Gearbox Pool? Or is it some other scenario?)
• Establish unit test needs (pass/fail settings, helper functions, etc.)
• Establish happy path and unhappy path tests.
• Finalize tests

Conversion from native asset to dieselToken is lossy

Context from chat w/ 0xValJohn:

Repo [link](https://github.com/0xValJohn/foundry_strategy_mix/blob/76e1feb53121e78c4a15cb00394aba42be7abd9b/src/Strategy.sol#L178)
Extra Notes:
It looks like it's related to how expectedLiquidity is calculated here and here (via timestamp)

Investigating the 'lossy-ness':

• Determine what values are being compared (on the Yearn accounting side, and the return value side of things). I assume it is estimatedTotalAssets()

  • Look through the code and make sense of the function calls and implementation

• Assess possible areas of lost accuracy (rounding errors, etc.)

  • console.log all values throughout calculation of return value && estimatedAssets value

• Provide a run-down of what was found via investigation && resulting action items