stevefaulkner/wcagparsing

wcag parsing error bookmarklet

wcagparsing's Issues

Show upstream errors that can generate "Unclosed element" errors

On this page I used the bookmarklet called "Check serialized DOM of current page," and it generated 30 errors and warnings.

I then used the bookmarklet called "Check for WCAG 2.0 parsing compliance," and 8 "Unclosed element" errors remained visible.

However, I believe those "unclosed error elements" are not a root problem; rather they are a byproduct of one or the other of two upstream errors that were filtered out by the parsing compliance bookmarklet:

• "End tag form seen, but there were open elements"
• "Saw a form start tag, but there was already an active form element..."

I therefore request that the parsing bookmarklet showthose two upstream errors because:

1. They help explain the "unclosed error elements" that otherwise simply look like false positives.
2. Because they reflect nesting errors, they are relevant to the WCAG 2.0 parsing requirement in their own right.

The bookmarklet is not filtering out some issues that I think it should

For example, it is not filtering out "Attribute name not allowed on element h1 at this point" when an

element has a null "name" attribute.

Also, it doesn't filter out "Attribute is_webform_submit not allowed on element button at this point" when a element has a null "is_webform_submit" attribute.

As far as I can tell, those issues do not violate WCAG SC 4.1.1, so they should be filtered out.

BTW, don't ask me why those attributes are present - it's not my code. These are just two examples, but we are finding hundreds of similar issues that are not getting filtered out.

The bookmarklet does not filter out the warning 'Trailing slash on void elements has no effect and interacts badly with unquoted attribute values.'

The bookmarklet does not filter out the warning "Trailing slash on void elements has no effect and interacts badly with unquoted attribute values.", which the W3C / Nu HTML Validator started outputting recently (presumable mid to late October).
This warning seems to replace the earlier warning "Self-closing tag syntax in text/html documents is widely discouraged; (…)", which I started noticing in September.

These warnings are about issues that aren't violations on WCAG SC 4.1.1.

Bookmarklet does not filter out unrecognized attribute errors

This issue is related to #5.

Disregarding the special case of "ng-" attributes, in general the bookmarklet does not filter out unrecognized attribute errors. (These are errors of the form "Attribute x not allowed on element y at this point".)

My sense is that these errors shouldn't remain in the results. For reference, WCAG 2.0 Parsing Criterion is a PITA (2015) says unrecognized attributes are not WCAG parsing failures, and they are not listed in WCAG 2.1 parsing error bookmarklet (2019).

Please add a licence to the repository

Could you please add a licence to the repository? Without a licence, the code is fully copyrighted. As a consequence, anyone who wants to reuse or modify the code needs to ask permission in advance.

This is, to my knowledge, the general rule with source code (or any other "creative works"): if no open-source licence is specified, the work is not open source but fully copyrighted.

Content model nesting failures should not be 4.1.1 failures

Currently

The Nu Validator reports nesting errors like this:

Element X not allowed as child of element Y in this context

Such nesting errors are usually content model errors, not syntax errors. (See discussion: w3c/wcag#978)

The bookmarklet is currently not filtering out content model failures, which should pass WCAG SC 2.1.1 Parsing.

Proposed

In the short term, please add a note in the bookmarklet download page.

Note: When the Nu HTML Validator reports "Element X not allowed as child of element Y in this context", not all such errors are failures of 4.1.1 Parsing. See wcag/issues/978

If it later turns out 4.1.1 is not fully and retroactively deprecated in the WCAG 2.2 time frame, then we might ought to go further and change the bookmarklet filter itself.