stevejenkins/opendkim-fedora

SPEC files and Patches for OpenDKIM Fedora / EPEL RPMs

OpenDKIM-Fedora

This git repo contains:

• SPECS/opendkim.spec - spec file for the OpenDKIM package I maintain in Fedora & EPEL (https://admin.fedoraproject.org/pkgdb/acls/name/opendkim/)

• PATCHES - patches for the spec file (as needed)

• CONTRIB - various files I maintain and contribute to the OpenDKIM upstream source

NOTE: As of 2.10.1-5, the systemd and SystemV versions of this spec file have been combined in the OpenDKIM-Fedora repo, and the OpenDKIM-SysV repo at http://github.com/stevejenkins/OpenDKIM-SysV/ has been abandonded.

CONTRIBUTORS: Please do pull requests in the "develop" branch only. The "master" branch is just for release versions. Thanks!

For official source code and documentation, please visit http://opendkim.org/

For documentation on installing and configuring the Fedora/RHEL packages built using the files in this repo, please visit http://www.stevejenkins.com/blog/2011/08/installing-opendkim-rpm-via-yum-with-postfix-or-sendmail-for-rhel-centos-fedora/

Find/follow/friend me at:

• http://www.stevejenkins.com/
• http://stevej.fedorapeople.org/
• https://linkedin.com/in/sjjenkins/
• https://facebook.com/SteveJenkinsBiz
• https://twitter.com/sjjenkins/

opendkim-fedora's Issues

Enable --with-lua

Would it be possible to enable lua support, so we can use SetupPolicyScript, ScreenPolicyScript and FinalPolicyScript ?

I'll do a rebuild now for myself, but including this in EPEL might be fantastic for more people.

Need custom init script setup parameters

• Create a %{sysconfdir}/sysconfig/%{name} file which will contain simply:

# Uncomment the following line to disable automatic DKIM key creation
# AUTOCREATE_DKIM_KEYS=NO
#
# Set the default selector
# DKIM_SELECTOR=default

• And then in the init script, after you set any default options,
  this will allow the sysadmin to override any of them (s)he needs:

[ -f %{sysconfdir}/sysconfig/%{name} ] && \
 . %{sysconfdir}/sysconfig/%{name}

• We set the DKIM_SELECTOR in the init script, but not the other one.

Include a sample SigningTable

Per Todd Lyons:

I suggest you consider including a sample signing_table file with some
verbose comments, maybe something like this:

# The following wildcard type works if
# refile:/path/to/signing_table is specified in
# the opendkim.conf
# *@example.com ...blahblah
#
# If refile: is not specified in opendkim.conf, then the matching
# occurs in the order:
# [email protected], [email protected], user@name
# full.host.name, and finally just user
# example.com ...blahblah

Wrong stop priority in init script patch

The current 2.4.2-2 init script patch reads:

-# chkconfig: 2345 41 61
+# chkconfig: - 41 61

It should read:

-# chkconfig: 2345 41 61
+# chkconfig: - 41 59

http://fedoraproject.org/wiki/Packaging:SysVInitScript#Chkconfig_Header says:

By default, you should set the <endpriority> equal to 100 - <startpriority>

Need SELinux Policy

Comparable errors to:

https://bugzilla.redhat.com/show_bug.cgi?id=718219

Keygen on start

Fix linebreaks for message echo on service start and restart relating to default keygen.

opendkim.pid is placed in legacy directory on Fedora 34

Dear maintener,
Thank you for your nice works.

I installed opendkim-2.11.0-0.18.fc34.x86_64, and then I get a warning as follows:

Jul 23 22:22:33 fedora systemd[1]: /usr/lib/systemd/system/opendkim.service:12: PIDFile= references a path below legacy directory /var/run/, updating /var/run/opendkim/opendkim.pid → /run/opendkim/opendkim.pid; please update the unit file accordingly.

Fix stats directory issues

We have stats capability enabled by default in the
binary, but not in the config file:

1. In opendkim.conf, the statistics directive is commented out. This
   is good because the defined stats directory is /var/opendkim/stats,
   which does not exist because /var/opendkim is not owned by the
   opendkim package. This is what /var/spool/opendkim was created for,
   so the path in the config file (even though it's commented out) should
   be changed to /var/spool/opendkim.
2. In the same vein, the filename "stats" could be very confusing to
   someone looking at this for the first time. I ask that you consider
   naming it stats.txt to clearly indicate to people that it's just a
   plain text file.
3. Since we enable stats by default, we should include the script and
   readme for stats:

%doc contrib/stats/README.opendkim-reportstats
install contrib/stats/opendkim-reportstats

to

%{prefix}/bin/opendkim-reportstats

modify the opendkim-reportstats to use the defaults you specify in 1
and 2 above. Use either or sed or awk or whatever you can to make
that work.

Remove Library from Package Description

The description for the main package includes "library" which appears in the Add/Remove software interface in Fedora, but the library is technically a separate package.