Giter Site home page Giter Site logo

stanpumpr's People

Contributors

daattali avatar fifteenforty avatar olofsen avatar stevenlshafer avatar trshafer avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar

stanpumpr's Issues

Button colours should be more intuitive

I think there should be a more consistent colour scheme, where "Cancel" buttons are just grey and "Delete" buttons are red.

For example, double click on the plot to add a drug, the Cancel button is orange and delete is green. Those colours make give the user too many things to focus on and it's distracting.

Effect and plasma site targeting mode

Graph bolus and infusion rate over time to achieve a target (reverse of current mode)

May be in useful in research for situations where targets are recorded, not infusion rates.

Reference time is not persisted through bookmarks

Although it appears that the list of reference times options is static, it is not as it can be overriding either manually or automatically with the current time. This is could be fixed by altering onRestored() (complex) or the field could be replaced with a textInput() (simple).

MIT license contradicted by README

The package is under MIT license, which explicitly allows commercial use.

Yet the following excerpt from the README attempts to restrict commercial use and even states "all rights reserved".

Companies seeking to develop such systems should contact Dr. Shafer to request written permission to incorporate stanpumpR into their products. 
Without written permission, stanpumpR must not be incorporated into commercially available systems.

It is inconsistent and, although I am not a lawyer, I would imagine the MIT license superseeds your note anyway.

Add multiple models for each drug

The ideal implementation would be able to demonstrate multiple plasma and effect site concentration prediction lines, with one for each model.

The tool could then be used to compare the outcomes of various models, which would be excellent for teaching.

Add support for shinylive

As the documentation reads: "Shinylive allows you to run Shiny applications entirely in a web browser, without the need for a separate server"

stanpumpR should be faster, more responsive and more reliable when run directly in the browser. As it has no external datasource dependencies, this is the ideal way to run it!

https://github.com/posit-dev/r-shinylive

Modal intro text shows on server reconnect

This is very disruptive when using application for an extended period and the server connection is interrupted (for example, by a shinyapps.io server sleeping, or a bad internet connection)

Email slides won't send

Reported by @StevenLShafer.

stanpumpR is no longer able to send e-mail. This is the error message from the stanpumpR log:

2022-10-17T20:07:03.758416+00:00 shinyapps[861505]: Address is OK
2022-10-17T20:07:07.425484+00:00 shinyapps[861505]: input$sendSlide 1
2022-10-17T20:07:07.428221+00:00 shinyapps[861505]: Sending email to [email protected]
2022-10-17T20:07:07.429311+00:00 shinyapps[861505]: In function sendSlide()
2022-10-17T20:07:08.521821+00:00 shinyapps[861505]: Saving PPTX
2022-10-17T20:07:08.544217+00:00 shinyapps[861505]: Starting ggexport()
2022-10-17T20:07:08.549076+00:00 shinyapps[861505]: [1] "Slides/Preview.1.221017-200707%!d(MISSING).png"
2022-10-17T20:07:09.144123+00:00 shinyapps[861505]: file saved to Slides/Preview.1.221017-200707%!d(MISSING).png
2022-10-17T20:07:09.144521+00:00 shinyapps[861505]: Fixing Units for export
2022-10-17T20:07:09.145349+00:00 shinyapps[861505]: Creating workbook
2022-10-17T20:07:09.156248+00:00 shinyapps[861505]: Writing covariates
2022-10-17T20:07:09.189637+00:00 shinyapps[861505]: Writing dose table
2022-10-17T20:07:09.446145+00:00 shinyapps[861505]: Writing simulation results
2022-10-17T20:07:09.453801+00:00 shinyapps[861505]: Writing results for plotting
2022-10-17T20:07:09.461151+00:00 shinyapps[861505]: Writing PK parameters

2022-10-17T20:07:09.461682+00:00 shinyapps[861505]: Drug =
2022-10-17T20:07:09.464333+00:00 shinyapps[861505]: Error in value[3L] :
2022-10-17T20:07:09.464343+00:00 shinyapps[861505]: (converted from warning) Error in which: object 'drugDefaults_global' not found
2022-10-17T20:07:09.464348+00:00 shinyapps[861505]: Calls: local ... tryCatch -> tryCatchList -> tryCatchOne ->
2022-10-17T20:07:09.464695+00:00 shinyapps[861505]: Error detected in stanpumpR
2022-10-17T20:07:09.464705+00:00 shinyapps[861505]: Error in value[3L] :
2022-10-17T20:07:09.464717+00:00 shinyapps[861505]: (converted from warning) Error in which: object 'drugDefaults_global' not found
2022-10-17T20:07:09.464730+00:00 shinyapps[861505]: Calls: local ... tryCatch -> tryCatchList -> tryCatchOne ->

Crash on load when running on shinyapps.io

Bug introduced by PR #80.

The '%btwn%' function is actually used and should not have been deleted. Deleting this function causes a crash when the application is run on shinyapps.io.

Bug with "Max Time" input

To reproduce:

  • Have only one drug in the table
  • Set the time to 20
  • Set "Max Time" to 10 (it was previously 60 by default)
  • You'll get a nothing plot. Now set Max Time back to 60 -- nothing happens. You must set Max Time to some other value and then back to 60 in order for the plot to come back

drugs reactive variable is set from the output of two different functions

The reactive value drugs is set from both of these functions. There should be enforcement that these two functions return the same data types.

stanpumpR/server.R

Lines 248 to 256 in 9fe8753

newDrugs <- recalculatePK(
isolate(drugs()),
drugDefaults(),
age = age(),
weight = weight(),
height = height(),
sex = sex()
)
drugs(newDrugs)

stanpumpR/server.R

Lines 392 to 400 in 9fe8753

newDrugs <- processdoseTable(
DT,
ET,
drugs(),
plotMaximum,
prior,
plotRecovery
)
drugs(newDrugs)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.