stolsma/authpack

Package of distributed client and server OAuth2 classes

authpack's Issues

multiple response types

more of a question. I do not completely understand the behavior if multiple response_types are requested, and what this code here does:

// Handle the different registered grant types, see 1.3/3.1.1 of OAuth2 Specs.
var rt = self.responseTypes;
for (var i=0; i < rt.length; i += 2) {
if (rt[i][0] === options.response_type) return rt[i+1](req, res, options);
}

A bit more explanation in the source would be great.

split this in multiple npms

Hi there,
thanks a lot for putting a lot of effort into this. It is very helpful for me. May I suggest that you consider splitting this into multiple npms? It makes usage and contributing much easier, and often simplifies testing as well. A good example for this would be passport (passportjs.org). Perhaps one for the client side, one for the overall server, and one with the server building blocks?

Martin

script in package.json for vows needs path

You might want to change the script test in package.json from

"test": "vows ...

to

"test": "node_modules/.bin/vows

to make sure that you use the correct version and that it works with travis-ci.org (which I encourage you to use, it's free and great for nodejs)