storefront-foundation/magento2-connector

A Magento 2 connector for React Storefront

magento2-connector's Issues

Add eslint

Products and sub categories not loading

Hello there

I recently configured this react store with my magento running on server, I am able to load the home page with categories being loaded from magento as show in the picture

but when I am clicking on a category it is loading and empty product page

also in the cmd I am getting this error

and sub categories also showing 404 when clicking on for example sub category of men->tops

can any suggest a solution like in my case categories are loading fine from magento only

thanks

[Low Priority] ERR_HTTP_HEADERS_SENT warning

Response object of NextJS shows this error when we're setting multiple "set-cookie" headers, which is required by the logic of session handling. I'm still not clear how to fix this issue. I played with different suggestions from here: https://stackoverflow.com/questions/52122272/err-http-headers-sent-cannot-set-headers-after-they-are-sent-to-the-client, but it wasn't helpful in our case. So probably it's something nextjs specific.

Ref: https://moovweb.atlassian.net/browse/PTR-14

error connecting magento locally

Hi guys,
First of all thanks for the great work!

I'm trying to test it locally. I've followed the steps about using magento connector. I've one local magento setup on magento.test URL, and set up .env file like
LEGACY_BACKEND_DOMAIN=magento.test LEGACY_BACKEND_HOST_HEADER=magento.test M2_CONFIG_HOST=http://magento.test

but when I npm start, it crashes with invalid json error which is actually a 500 internal error for getting the app data.

Did I miss any steps? thanks

No matching version found for create-react-storefront@^8.014.0

Hello there, thanks for your awesome work!

However when I tried to follow the documentation, this command gave me an error

npm create react-storefront@^8.014.0 my-m2-app

npm ERR! code ETARGET npm ERR! notarget No matching version found for create-react-storefront@^8.014.0. npm ERR! notarget In most cases you or one of your dependencies are requesting npm ERR! notarget a package version that doesn't exist.

Seems the create-react-storefront version 8.014.0 is not available yet on npm.
Could you please help me to check?

Thanks

[Low Priority] .eslintrc.js - parsing error: "parserOptions.project" has been set for @typescript-eslint/parser

• Open .eslintrc.js file in code editor that supports/has ESLint extension turned on.
• See the error:

Parsing error: "parserOptions.project" has been set for @typescript-eslint/parser.
The file does not match your project config: .eslintrc.js.
The file must be included in at least one of the projects provided.

Subcategory link error

Hello there

I was trying this connector with my local Magento2 installation (with sample data). The category link works normally, but when I tried to navigate the sub category link (example: /s/training/training-video.html), I got this error

Error: The providedasvalue (/s/training/training-video.html) is incompatible with thehrefvalue (/s/[subcategoryId]). Read more: https://err.sh/vercel/next.js/incompatible-href-as
Seems the <Link/> component was using href as /s/[subcategoryId] and it's incompatible with /s/training/training-video.html (there is another slash)

Could you please check it?

Thanks!

Starter Demo App crashes on installing react-storefront-magento2-connector

Whenever I install the react-storefront-magento2-connector package in the starter demo app, the app crashes giving the following error:

And gone after uninstalling that specific package

Remove `create-index` package

Leave only src/index.js file for general exports

Add to cart from CMS slot product links results in an error

Ref: https://moovweb.atlassian.net/browse/PTR-13

Add to cart is not working .

When click on Add to cart button , i am getting the below Error message from Server console .

API resolved without sending a response for /api/cart/add?v=development, this may result in stalled requests.

And the request in Chrome network Tab showing pending for long time .

Any fix for this ,

Thanks,

No option for store code, only "default" store code works

This is not documented, but you can not configure the store code that is used in the GraphQL request, resulting in problems using the connector.

From Magento 2:

The store that was requested wasn't found. Verify the store and try again.

App:

FetchError: invalid json response body at http://*****/graphql reason: Unexpected token < in JSON at position 0

Source of problem:

magento2-connector/src/fetchWithGraphQl.ts

Line 15 in 4ce08c3

Store: 'default',

If you do not use "default" as your store's default code, then you can not use the connector. This should be resolved by configuration option to support Magento 2 multi-store environments. Similar to setting ENV for backend host, you must also be able to set the store code.