Giter Site home page Giter Site logo

Comments (14)

MichaelDeBoey avatar MichaelDeBoey commented on July 20, 2024 1

@uppe-r react-treebeard uses also the deprecated React.PropTypes, like you can see in treebeard.js L36-L46, header.js L42-L49, node.js L100-L107 & decorators.js L97-L105

from react-treebeard.

nocategory avatar nocategory commented on July 20, 2024 1

@MichaelDeBoey You're right, only looked at the first files in the Warning.

from react-treebeard.

MichaelDeBoey avatar MichaelDeBoey commented on July 20, 2024 1

@uppe-r I'll try to look at it (again) tonight, but I thought that the tests were failing me and I couldn't seem to pass them so... 😕

from react-treebeard.

MichaelDeBoey avatar MichaelDeBoey commented on July 20, 2024 1

@uppe-r Tried my best in #67, but still get some errors 😕
Maybe you can help?

from react-treebeard.

MichaelDeBoey avatar MichaelDeBoey commented on July 20, 2024 1

Oh sh*t I thought the test were failing for some other reason... 😕

So I guess I can just delete the test using reactid...

from react-treebeard.

nocategory avatar nocategory commented on July 20, 2024 1

Guess so @MichaelDeBoey . Doesn't make sense to keep something that isn't used anymore and just causes errors, right? 😆

from react-treebeard.

nocategory avatar nocategory commented on July 20, 2024

This error comes from velocity-react. It is fixed in v.1.3.0 by this pull request

from react-treebeard.

nocategory avatar nocategory commented on July 20, 2024

@MichaelDeBoey Hey! I can try. I'm kinda new, but from what I managed to find, with React v15 data-reactid is no longer used on every node (only server generated). As so, why are there still tests for reactid's?

from react-treebeard.

MichaelDeBoey avatar MichaelDeBoey commented on July 20, 2024

@uppe-r That's strange 😕 Their test are still passing, but they shouldn't if it's no longer used since React v15.0 ... 😕

from react-treebeard.

nocategory avatar nocategory commented on July 20, 2024

@MichaelDeBoey The last PR's and non-PR's I see on Travis were using [email protected], like https://travis-ci.org/alexcurtis/react-treebeard/builds/197948568#L849

from react-treebeard.

MichaelDeBoey avatar MichaelDeBoey commented on July 20, 2024

Should be fixed now 🙂

@alexcurtis Can you look at #67 please?

from react-treebeard.

MichaelDeBoey avatar MichaelDeBoey commented on July 20, 2024

@uppe-r Do you know a way to increase coverage again?
Don't see what caused the decrease 😕

from react-treebeard.

nocategory avatar nocategory commented on July 20, 2024

@MichaelDeBoey No idea

from react-treebeard.

MichaelDeBoey avatar MichaelDeBoey commented on July 20, 2024

v2.0.0is released as of now! 🙂

from react-treebeard.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.