Comments (14)
@uppe-r react-treebeard
uses also the deprecated React.PropTypes
, like you can see in treebeard.js
L36-L46, header.js
L42-L49, node.js
L100-L107 & decorators.js
L97-L105
from react-treebeard.
@MichaelDeBoey You're right, only looked at the first files in the Warning.
from react-treebeard.
@uppe-r I'll try to look at it (again) tonight, but I thought that the tests were failing me and I couldn't seem to pass them so... 😕
from react-treebeard.
@uppe-r Tried my best in #67, but still get some errors 😕
Maybe you can help?
from react-treebeard.
Oh sh*t I thought the test were failing for some other reason... 😕
So I guess I can just delete the test using reactid
...
from react-treebeard.
Guess so @MichaelDeBoey . Doesn't make sense to keep something that isn't used anymore and just causes errors, right? 😆
from react-treebeard.
This error comes from velocity-react. It is fixed in v.1.3.0 by this pull request
from react-treebeard.
@MichaelDeBoey Hey! I can try. I'm kinda new, but from what I managed to find, with React v15 data-reactid is no longer used on every node (only server generated). As so, why are there still tests for reactid's?
from react-treebeard.
@uppe-r That's strange 😕 Their test are still passing, but they shouldn't if it's no longer used since React v15.0
... 😕
from react-treebeard.
@MichaelDeBoey The last PR's and non-PR's I see on Travis were using [email protected], like https://travis-ci.org/alexcurtis/react-treebeard/builds/197948568#L849
from react-treebeard.
Should be fixed now 🙂
@alexcurtis Can you look at #67 please?
from react-treebeard.
@uppe-r Do you know a way to increase coverage again?
Don't see what caused the decrease 😕
from react-treebeard.
@MichaelDeBoey No idea
from react-treebeard.
v2.0.0
is released as of now! 🙂
from react-treebeard.
Related Issues (20)
- Example doesn't work HOT 2
- Is it possible to change the Icon? HOT 1
- [Question] Is it possible to expand node without selecting it? HOT 15
- How to get name for parent node?
- Example code does not work as expected. Parent and child nodes all get highlighted when expanded
- How to handle right click events over folders and nodes (files)? HOT 4
- style object is mutated by a component it's passed to HOT 1
- its impossible to update treebeard from client side dynamically?
- How to Pass nodes in custom toggle decorater
- Performance for large numbers of files
- Update data when new file is added HOT 1
- Using array for multiple root nodes fails when interacting with tree (example included) HOT 3
- responsive
- Uncaught Invariant Violation: Element type is invalid: expected a string (for built-in components) or a class/function (for composite components) but got: object. Check the render method of `VelocityTransitionGroup`. HOT 2
- Show buttons to the right when hovering on a node? HOT 1
- [Request] Do not show polygon if no children are provided.
- Dynamically add children through API
- [Question] Display more than the name HOT 1
- [Bug] Arrows in markdown are way off on the right HOT 1
- [Question] Remove onToggle from file nodes? HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from react-treebeard.