str4d/pinentry-rs

Rust interface for pinentry binaries

pinentry

pinentry is a library for interacting with the pinentry binaries available on various platforms.

Usage

Add this line to your Cargo.toml:

pinentry = "0.5"

See the documentation for examples.

pinentry requires Rust version 1.51 or greater.

License

Licensed under either of

• Apache License, Version 2.0, (LICENSE-APACHE or http://www.apache.org/licenses/LICENSE-2.0)
• MIT license (LICENSE-MIT or http://opensource.org/licenses/MIT)

at your option.

Contribution

Unless you explicitly state otherwise, any contribution intentionally submitted for inclusion in the work by you, as defined in the Apache-2.0 license, shall be dual licensed as above, without any additional terms or conditions.

pinentry-rs's Issues

Missing percent-escaping on the data line response

First of all, thanks for these bindings! They're a pleasure to use.

The Assuan protocol documents that certain characters must be percent-escaped, and that others may be:

Raw data returned to client. There must be exactly one space after the ’D’. The values for ’%’, CR and LF must be percent escaped; these are encoded as %25, %0D and %0A, respectively. Only uppercase letters should be used in the hexadecimal representation. Other characters may be percent escaped for easier debugging. All Data lines are considered one data stream up to the OK or ERR response. Status and Inquiry Responses may be mixed with the Data lines.

Experimentally, pinentry.rs fails to unescape these sequences, mangling the user's input if it happens to contain escaped characters. I took a quick glance at the code, and it looks like the escaping probably needs to happen here:

pinentry-rs/src/assuan.rs

Line 194 in 030601d

Response::DataLine(SecretString::new(data.to_owned()))

I'm happy to take a stab at fixing this.