styladev/magentostylaconnect

The Styla Magento plugin

magentostylaconnect's Issues

Cannot log in to admin panel

Due to this line

magentoStylaConnect/app/code/community/Styla/Connect/Model/Styla/Api/Oauth/Connector.php

Line 228 in 8171512

$role->setTree_level(1);

we are not able to log in to admin panel. User tree level should be 2 and not 1

Weird behaviour during SEO data retrieval

The method Styla_Connect_Model_Styla_Api::getPageSeoData() is working in a weird way IMHO. If, for some reason, the webservice is not reachable, the method returns an empty array for 5 minutes. I can understand the reasoning behind this choice, but it has very strange consequences.

SEO data is usually cached for a certain amount of time (3600 seconds in our case). The result of the webservice request is stored in Magento cache, so far so good. If one of the requests fails, the already generated cache entries are simply ignored because of these lines:

        if($cache->load('styla_seo_unreachable')) {
            return array();
        }

The service might be temporarily unreachable (actually happens quite often in our case, once every 20 minutes), but even if this is the case, the code should at least check if a cache result is already available for the request before returning an empty array. Instead, one failure prevents all pages from displaying SEO information for 5 minutes. It is extremely important that this information is available for services that parse it, e.g. Facebook. With one error all pages become unusable.

Is the problem know on your side? Can you look into that or should I work on a PR? Thank you.