sub-kek/customdiscs-svc

customdiscs-svc's Issues

403 and proxy support or caching

Youtube blocks ip (for over a week) if you make too many requests

So, it would be nice if you added a proxy support or caching if a disc made with createyt

Logs:

[19:56:59] [Region Scheduler Thread #0/INFO]: Trard issued server command: /cd createyt https://www.youtube.com/watch?v=faAYOXlh2G0 "test"
[19:57:00] [lava-daemon-pool-playback-1-thread-1/ERROR]: [io.github.subkek.customdiscs.libs.com.sedmelluq.discord.lavaplayer.track.playback.LocalAudioTrackExecutor] Error in playback of faAYOXlh2G0
io.github.subkek.customdiscs.libs.com.sedmelluq.discord.lavaplayer.tools.FriendlyException: Something broke when playing the track.
        at io.github.subkek.customdiscs.libs.com.sedmelluq.discord.lavaplayer.tools.ExceptionTools.wrapUnfriendlyExceptions(ExceptionTools.java:45) ~[CustomDiscs-1.3.9(2).jar:?]
        at io.github.subkek.customdiscs.libs.com.sedmelluq.discord.lavaplayer.track.playback.LocalAudioTrackExecutor.execute(LocalAudioTrackExecutor.java:113) ~[CustomDiscs-1.3.9(2).jar:?]
        at io.github.subkek.customdiscs.libs.com.sedmelluq.discord.lavaplayer.player.DefaultAudioPlayerManager.lambda$executeTrack$1(DefaultAudioPlayerManager.java:324) ~[CustomDiscs-1.3.9(2).jar:?]
        at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1144) ~[?:?]
        at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:642) ~[?:?]
        at java.lang.Thread.run(Thread.java:1583) ~[?:?]
        Suppressed: io.github.subkek.customdiscs.libs.com.sedmelluq.discord.lavaplayer.tools.exception.EnvironmentInformation:
  lavaplayer.version: 0eaeee195f0315b2617587aa3537fa202df07ddc-SNAPSHOT
  os.arch: amd64
  os.name: Linux
  os.version: 6.1.0-22-amd64
  java.vendor: Amazon.com Inc.
  java.version: 21.0.3
  java.runtime.version: 21.0.3+9-LTS
  java.vm.version: 21.0.3+9-LTS
Caused by: java.lang.RuntimeException: Not success status code: 403
        at io.github.subkek.customdiscs.libs.com.sedmelluq.discord.lavaplayer.tools.io.PersistentHttpStream.validateStatusCode(PersistentHttpStream.java:88) ~[CustomDiscs-1.3.9(2).jar:?]
        at io.github.subkek.customdiscs.libs.com.sedmelluq.discord.lavaplayer.tools.io.PersistentHttpStream.attemptConnect(PersistentHttpStream.java:124) ~[CustomDiscs-1.3.9(2).jar:?]
        at io.github.subkek.customdiscs.libs.com.sedmelluq.discord.lavaplayer.tools.io.PersistentHttpStream.connect(PersistentHttpStream.java:106) ~[CustomDiscs-1.3.9(2).jar:?]
        at io.github.subkek.customdiscs.libs.com.sedmelluq.discord.lavaplayer.tools.io.PersistentHttpStream.internalRead(PersistentHttpStream.java:158) ~[CustomDiscs-1.3.9(2).jar:?]
        at io.github.subkek.customdiscs.libs.com.sedmelluq.discord.lavaplayer.tools.io.PersistentHttpStream.read(PersistentHttpStream.java:174) ~[CustomDiscs-1.3.9(2).jar:?]
        at java.io.DataInputStream.readUnsignedByte(DataInputStream.java:295) ~[?:?]
        at java.io.DataInputStream.readByte(DataInputStream.java:275) ~[?:?]
        at io.github.subkek.customdiscs.libs.com.sedmelluq.discord.lavaplayer.container.matroska.format.MatroskaEbmlReader.readEbmlInteger(MatroskaEbmlReader.java:39) ~[CustomDiscs-1.3.9(2).jar:?]
        at io.github.subkek.customdiscs.libs.com.sedmelluq.discord.lavaplayer.container.matroska.format.MatroskaFileReader.readNextElement(MatroskaFileReader.java:46) ~[CustomDiscs-1.3.9(2).jar:?]
        at io.github.subkek.customdiscs.libs.com.sedmelluq.discord.lavaplayer.container.matroska.MatroskaStreamingFile.readFile(MatroskaStreamingFile.java:74) ~[CustomDiscs-1.3.9(2).jar:?]
        at io.github.subkek.customdiscs.libs.com.sedmelluq.discord.lavaplayer.container.matroska.MatroskaAudioTrack.loadMatroskaFile(MatroskaAudioTrack.java:52) ~[CustomDiscs-1.3.9(2).jar:?]
        at io.github.subkek.customdiscs.libs.com.sedmelluq.discord.lavaplayer.container.matroska.MatroskaAudioTrack.process(MatroskaAudioTrack.java:35) ~[CustomDiscs-1.3.9(2).jar:?]
        at io.github.subkek.customdiscs.libs.com.sedmelluq.discord.lavaplayer.track.DelegatedAudioTrack.processDelegate(DelegatedAudioTrack.java:25) ~[CustomDiscs-1.3.9(2).jar:?]
        at io.github.subkek.customdiscs.libs.com.sedmelluq.discord.lavaplayer.source.youtube.YoutubeAudioTrack.processStatic(YoutubeAudioTrack.java:83) ~[CustomDiscs-1.3.9(2).jar:?]
        at io.github.subkek.customdiscs.libs.com.sedmelluq.discord.lavaplayer.source.youtube.YoutubeAudioTrack.processStaticWithRetry(YoutubeAudioTrack.java:65) ~[CustomDiscs-1.3.9(2).jar:?]
        at io.github.subkek.customdiscs.libs.com.sedmelluq.discord.lavaplayer.source.youtube.YoutubeAudioTrack.process(YoutubeAudioTrack.java:52) ~[CustomDiscs-1.3.9(2).jar:?]
        at io.github.subkek.customdiscs.libs.com.sedmelluq.discord.lavaplayer.track.playback.LocalAudioTrackExecutor.execute(LocalAudioTrackExecutor.java:101) ~[CustomDiscs-1.3.9(2).jar:?]
        ... 4 more

Problematic YouTube player script base.js detected (issue detected with script: no n function match).

I use 1.4.4 version. I tried to play a youtube disc, but there is an error:

[22:08:04 ERROR]: [io.github.subkek.customdiscs.libs.dev.lavalink.youtube.cipher.SignatureCipherManager] Problematic YouTube player script /s/player/20dfca59/player_ias.vflset/de_DE/base.js detected (issue detected with script: no n function match). Dumped to /tmp/lavaplayer-yt-player-script9162208958155913932.js

[Bug] burning YouTube videos to discs doesn't work

it says "Error while loading audio!" and nothing happens(also nothing gets printed into console)

java.lang.InterruptedException: sleep interrupted

Sometimes plugin logs

[08:54:21] [LavaPlayer/ERROR]: [CustomDiscs] Error while playing disc:
java.lang.InterruptedException: sleep interrupted
at java.lang.Thread.sleep0(Native Method) ~[?:?]
at java.lang.Thread.sleep(Thread.java:558) ~[?:?]
at java.util.concurrent.TimeUnit.sleep(TimeUnit.java:446) ~[?:?]
at io.github.subkek.customdiscs.LavaPlayerManager$LavaPlayer.startTrackJob(LavaPlayerManager.java:178) ~[CustomDiscs-1.3.9(2).jar:?]

However, I don't see any issues in game

/cd download игнорирует permissions?

Я выдал группе право "customdiscs.download", но когда человек в этой группе пытается загрузить трек, то ничего не происходит. Нет никакой ошибки. Я пытался выдать группе право "customdiscs.*", но происходит такая же проблема. При этом на меня (а я OP) эта команда реагирует.
Проблема происходит только с этой командой, например команда cd create отрабатывает как нужно.

Вот так это выглядит в консоли.

Suggestion: Make it possible to set custom model data required for discs to be accepted for burn.

Similar to the implementation of Plasmo Voice and its addon for discs, it would be great to have a way of making discs have certain characteristics so that it can be burned.

Duplication Bug

Error: [11:28:21 WARN]: [CustomDiscs] Task #8492174 for CustomDiscs v2.0.0 generated an exception
java.lang.ClassCastException: class org.bukkit.craftbukkit.block.CraftBlockState cannot be cast to class org.bukkit.block.Jukebox (org.bukkit.craftbukkit.block.CraftBlockState and org.bukkit.block.Jukebox are in unnamed module of loader java.net.URLClassLoader @41cf53f9)
at CustomDiscs-2.0.0.jar/io.github.subkek.customdiscs.PhysicsManager.stop(PhysicsManager.java:66) ~[CustomDiscs-2.0.0.jar:?]
at CustomDiscs-2.0.0.jar/io.github.subkek.customdiscs.PhysicsManager.lambda$start$0(PhysicsManager.java:85) ~[CustomDiscs-2.0.0.jar:?]
at CustomDiscs-2.0.0.jar/io.github.subkek.customdiscs.libs.com.tcoded.folialib.impl.SpigotImplementation.lambda$runTimer$4(SpigotImplementation.java:161) ~[CustomDiscs-2.0.0.jar:?]
at org.bukkit.craftbukkit.scheduler.CraftTask.run(CraftTask.java:88) ~[sparklypaper-1.21.1.jar:1.21.1-DEV-00d685c]
at org.bukkit.craftbukkit.scheduler.CraftScheduler.mainThreadHeartbeat(CraftScheduler.java:475) ~[sparklypaper-1.21.1.jar:1.21.1-DEV-00d685c]
at net.minecraft.server.MinecraftServer.tickChildren(MinecraftServer.java:1731) ~[sparklypaper-1.21.1.jar:1.21.1-DEV-00d685c]
at net.minecraft.server.dedicated.DedicatedServer.tickChildren(DedicatedServer.java:490) ~[sparklypaper-1.21.1.jar:1.21.1-DEV-00d685c]
at net.minecraft.server.MinecraftServer.tickServer(MinecraftServer.java:1603) ~[sparklypaper-1.21.1.jar:1.21.1-DEV-00d685c]
at net.minecraft.server.MinecraftServer.runServer(MinecraftServer.java:1309) ~[sparklypaper-1.21.1.jar:1.21.1-DEV-00d685c]
at net.minecraft.server.MinecraftServer.lambda$spin$0(MinecraftServer.java:335) ~[sparklypaper-1.21.1.jar:1.21.1-DEV-00d685c]
at java.base/java.lang.Thread.run(Thread.java:1583) ~[?:?]

Environment
Fork: https://github.com/SparklyPower/SparklyPaper
Version: 2.0.0

Reproduction Steps

1. Install CD
2. Create a YT disc
3. Insert disc to a Jukebox
4. Remove the disc
5. Audio still plays
6. You can spam remove the disc from the jukebox and it won't stop (disc will just keep coming out)