Giter Site home page Giter Site logo

jshint-jenkins-checkstyle-reporter's People

Contributors

obscurerichard avatar sublimeye avatar

Stargazers

 avatar

Watchers

 avatar  avatar  avatar

jshint-jenkins-checkstyle-reporter's Issues

Property check in makeAttribute fails on falsy values

This code's check using !valueObject[attr] will fail on falsy values such as '0':

    function makeAttribute(attr, valueObject) {
        if (!valueObject[attr]) {
            throw Error('No property '+attr+' in error object');
        }

        return ' ' + attr + '="'+valueObject[attr]+'"';
    }

This failed on valid input for me recently. The error object that the calling function was passing in had these values:

error: Object
column: 0
line: 262
message: "Identifier 'init_genrand' is not in camel case."
severity: "warning"
source: "jshint.W106"

This function threw an error 'No property column in error object'. This got swallowed by the higher level functions in grunt-contrib-jshint and grunt itself, alas, and was not obvious. I had to trace into his with Node Inspector to find the error.

A pull request is forthcoming to address this.

Jenkins breaks if XML report files have relative paths

Even though I'm specifying the source files to run through JSHint using absolute paths, the XML report file uses relative paths. And worse, they're relative to where those reports are stored (build/logs) instead of to the project root (where grunt is run).

Obviously this must be working for other people. Do I need to change something in the Jenkins project configuration?

Side note: the documentation mentions a JSHint Jenkins plugin which I cannot find, and it links to the Checkstyle plugin. Are these typos, or is there a secret JSHint plugin for Jenkins? :)

This reporter will add colors to your JSHint Trend reports in Jenkins, produced by JSHint Report Plugin.

The closest plugin I can find is one that runs JSLint itself, bypassing Grunt. Is this related?

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.