Comments (7)
Thank you very much for noticing, I didn't have twilight princess for gamecube,
so I guess I never got the chance of this happening to me.
I'll fix this in a couple hours.
ps: sorry for the late response, I saw this last week, but I didn't have time
to correct the bug since today.
Btw, what is the incorrect behavior? I'm gonna test it, I'm curious to see what
happens.
Original comment by [email protected]
on 3 Sep 2013 at 8:46
- Changed state: Started
from gcmm.
[deleted comment]
from gcmm.
I've been checking the code and even in the case when trying to open gczelda
file from the memory card and the code stomps with gczelda2, then it checks the
gamecode, and as it is different, it should proceed to the next file in the
entri list...
So, what is exactly the incorrect behavior and how to reproduce it?
ps: still, I agree it is better to just use stricmp
Original comment by [email protected]
on 3 Sep 2013 at 9:09
from gcmm.
A more thourough testing has revealed that the problem wasn't with the strnicmp
function, but with gamecode detection, as I stated earlier it should prevent
the behavior you experienced.
Your fix does indeed fix the bug, but the bug remains if you have 2 savegames
of the same game but from different regions, so the problem is with gamecode
detection.
I hope I can fix it soon.
Original comment by [email protected]
on 3 Sep 2013 at 10:14
from gcmm.
Ok, I think I nailed it. I (and others before me) incorrectly assumed that
CARD_init()can be used to set the company and the gamecode and that it can be
called as many times as wanted to change it. But that is wrong, this function
only works the first time, which makes sense, as a game will only use a single
company and gamecode for its savefiles.
I just need to change all the card_init calls for Card_setcompany and
card_setgamecode and card_getfilenum will work correctly, no need to change it
(as it is part of libogc I'd prefer to leave it as unchanged as possible).
The program has been working because the first call to card_init is made with
null params, so this allows to list all entries in the card. In fact I myself
fixed savegame restoring (which sometimes worked and sometimes didn't) by using
card_setcompany and card_setgamecode, and then I took on GCMM. Silly me I
didn't notice then.
Original comment by [email protected]
on 3 Sep 2013 at 11:34
from gcmm.
Done. I lost an mc in the process, I think it is because its old, as the
problems appear with older versions of gcmm and only in this mc (not a nintendo
MC).
_card_sectorerase failed whenever I tried to restore an image to that MC, I
couldn't find out why.
But the filename/region bug is fixed. Thanks again for noticing.
Original comment by [email protected]
on 3 Sep 2013 at 3:26
- Changed state: Fixed
from gcmm.
That make sense, I wasn't using CARD_init to set the gamecode or company
Original comment by [email protected]
on 6 Sep 2013 at 5:36
from gcmm.
Related Issues (20)
- Phantasy Star Online Plus Support HOT 5
- ZeldaTPConverter Error
- Add Support for Folders and List Files in Alphabetical Order HOT 19
- Move PSO save from Nintendont to Devolution? HOT 5
- Restoring Save Files to Official NGC Memory Card (Slot A, if it matters) HOT 7
- Restore Error HOT 6
- GCMM freeze on gamecube when you press Start to exit. Started with Action Replay. HOT 7
- How to Use Raw Tools HOT 6
- Support for Gamecube SD2SP2 HOT 30
- Support for exFAT for all interfaces (Gecko/SD2SP2/GCloader)
- How to install? HOT 4
- card.c HOT 18
- GameCube user and gcmm - reboot instructions? HOT 4
- SD2SP2 not working on version 15 HOT 18
- How to make a decent donation for suloku?
- How to make the GameCube version of GCMM output in 480i HOT 6
- GCMM 1.5.2 does not work anymore in Dolphin HOT 1
- No apps folder HOT 1
- CardMount - 2 wrong device in slot error HOT 1
- Failed to mount fat partition in sd2sp2 HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from gcmm.