sunrise-choir / flumedb-rs Goto Github PK
View Code? Open in Web Editor NEWLicense: GNU Lesser General Public License v3.0
License: GNU Lesser General Public License v3.0
Hi. Is the release on crates.io https://crates.io/crates/flumedb stable?
Hello ๐ฆ,
we (Rust group @sslab-gatech) found a memory-safety/soundness issue in this crate while scanning Rust code on crates.io for potential vulnerabilities.
flumedb-rs/src/go_offset_log.rs
Lines 212 to 221 in d6dbb60
Lines 330 to 341 in d6dbb60
Methods go_offset_log::read_entry()
& offset_log::read_entry()
create an uninitialized buffer and passes it to user-provided F
. This is unsound, because it allows safe Rust code to exhibit an undefined behavior (read from uninitialized memory).
This part from the Read
trait documentation explains the issue:
It is your responsibility to make sure that
buf
is initialized before callingread
. Calling read with an uninitializedbuf
(of the kind one obtains viaMaybeUninit<T>
) is not safe, and can lead to undefined behavior.
It is safe to zero-initialize the newly allocated u8
buffer before read_at()
, in order to prevent user-provided code from accessing old contents of the newly allocated heap memory.
Also, there are two nightly features for handling such cases.
Thank you for checking out this issue ๐
This will use slightly more disk space but means we don't need to go and hit the offset log for the entire message if needed.
To save some space in the future, we could store the message using cbor and transcode to json if needed.
A declarative, efficient, and flexible JavaScript library for building user interfaces.
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
An Open Source Machine Learning Framework for Everyone
The Web framework for perfectionists with deadlines.
A PHP framework for web artisans
Bring data to life with SVG, Canvas and HTML. ๐๐๐
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
Some thing interesting about web. New door for the world.
A server is a program made to process requests and deliver data to clients.
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Some thing interesting about visualization, use data art
Some thing interesting about game, make everyone happy.
We are working to build community through open source technology. NB: members must have two-factor auth.
Open source projects and samples from Microsoft.
Google โค๏ธ Open Source for everyone.
Alibaba Open Source for everyone
Data-Driven Documents codes.
China tencent open source team.