supernevi/karaokeprovider

A java based server to provide songs, videos and lyrics for karaoke machines like UltraStar Play

karaokeprovider's Issues

Architectual Tests

Is your feature request related to a problem? Please describe.

All contributors should program in the same style. For example, all dao classes should end up in the dao package, as well as all service classes in the service package, and so on. For this architectual tests are to be implemented, so that the defaults are kept by tests.

Improve code coverage / implement automated tests

Is your feature request related to a problem? Please describe.
Currently the app isn't fully automated tested

Describe the solution you'd like
Implement automated tests through all layers (dao, service, rest)

Fix code scanning alert - User-controlled data in numeric cast

Tracking issue for:

• https://github.com/supernevi/KaraokeProvider/security/code-scanning/1

Basic Authorization

Is your feature request related to a problem? Please describe.
By now all API calls are open without any authorization. But usually you only want some applications allow access to your song repository, especially if your server is hosted in the cloud.

Describe the solution you'd like
Some authorization routines should be available. This can be done with Basic OAuth authorization. For this, the server should generate a client id and a secret and store this information in a local file since this can be reused after restarting the server. I don't think that any encryption is needed here (for now)

REST-API documentation

Is your feature request related to a problem? Please describe.
Create REST-API documentation so anybody can see which calls are available.

Describe the solution you'd like
The documentation should be generated by the annotations in the RestController interfaces.

See: https://springdoc.org/v2/

codacy improvements and display codacy code quality badge in readme