suse-enceladus/azure-img-utils

azure-img-utils's Issues

Add force replace option for add image to offer method

Currently the code will replace an existing image version if a new one is added with same version string. Instead it would be helpful for the function to raise an error if the version already exists. Also, adding a force replace flag will allow the existing functionality to persist.

Error in cloud partner publish from CLI

09:35:19 ▶ azure-img-utils cloud-partner-offer publish --offer-id sles-15-sp4-byos-arm64 --notification-emails [email protected]
Unable to publish cloud partner offer
'AzureImage' object has no attribute 'publish_cloud_partner_offer'

No disk generations causes key error

When attempting to add an image to a generation when the offer has no generations yet the key does not exist diskGenerations. This leads to a key error.

Installation repository doesn't work

The section in the README regarding the installation refers to a OBS project, which does not contain python3-azure-img-utils anymore:

$ zypper ar http://download.opensuse.org/repositories/Cloud:/Tools/<distribution>
$ zypper refresh
$ zypper in python3-azure-img-utils

Cloud:Tools doesn't contain python3-azure-img-utils but Cloud:Tools:CI does.

Improve user feedback about async operations

Current version of the Azure SDK does NOT provide a proper object with the result for an asynchronous operation.
In image deletion, the result object is always None, no matter if the image is actually deleted or not, so it's not possible to provide accurate info to the cli user in some error scenarios.

It might be good to check the issue again in the future to fix it.

Raise exception when notification_emails is none

This is required when publishing an offer. When the value provided by CLI or config is None raise an exception. Otherwise the Azure MP API provides an unhelpful message:

Unable to publish cloud partner offer
400 Client Error: Bad Request for url: https://cloudpartner.azure.com/api/publishers/suse/offers/sles-15-sp3-chost-byos/publish?api-version=2017-10-31

Add Gallery Image Functions

It would be nice to include the gallery image functions. This is another way to create custom compute images that allows for sharing the images with other users/accounts.

Move functionality into class methods

Where the class methods call utility functions with similar names the code can move to the class method and the utility can be dropped. For example AzureImage.create_compute_image calls create_image to do the actual image creation. This can be consolidated in the class. This solves the name clashing issue and leaves utils modules for functions that don't fit nicely in the class or to prevent duplication.

CLI tests failing

Tests fail on assertion in python3.6 and click 7.0:

assert "Missing option '--blob-name'" in result.output

Because the output is:

Missing option "--blob-name"

We shouldn't rely on output of " vs ' in tests as this could change based on the version of click and/or python.