svalorzen/cpp-readline

A very simple C++ wrapper for GNU readline.

cpp-readline's Issues

Build failed due to "use of undeclared identifier" in two places

I was trying to build the example and it failed with the following output:

$make
Scanning dependencies of target cpp-readline
[ 25%] Building CXX object src/CMakeFiles/cpp-readline.dir/Console.cpp.o
.../cpp-readline/src/Console.cpp:100:13: error: 
      use of undeclared identifier 'history_set_history_state'
            history_set_history_state(emptyHistory);
            ^
/Users/its_behind_you/project_job/licpp/cpp-readline/src/Console.cpp:102:13: error: 
      use of undeclared identifier 'history_set_history_state'
            history_set_history_state(pimpl_->history_);
            ^
2 errors generated.
make[2]: *** [src/CMakeFiles/cpp-readline.dir/Console.cpp.o] Error 1
make[1]: *** [src/CMakeFiles/cpp-readline.dir/all] Error 2
make: *** [all] Error 2

Build failure due to std::unordered_map's explicit constructor

Using GCC 4.9.3:

FAILED: /usr/bin/c++   -Dcpp_readline_EXPORTS -g -fPIC -I../src \
-std=c++11 -Wall -Werror -pedantic -Weffc++ -MMD \
-MT src/CMakeFiles/cpp-readline.dir/Console.cpp.o \
-MF src/CMakeFiles/cpp-readline.dir/Console.cpp.o.d \
-o src/CMakeFiles/cpp-readline.dir/Console.cpp.o -c ../src/Console.cpp
../src/Console.cpp:28:44: error: converting to ‘CppReadline::Console::Impl::RegisteredCommands {aka std::unordered_map<std::basic_string<char>, std::function<int(const std::vector<std::basic_string<char> >&)> >}’ from initializer list would use explicit constructor ‘std::unordered_map<_Key, _Tp, _Hash, _Pred, _Alloc>::unordered_map(std::unordered_map<_Key, _Tp, _Hash, _Pred, _Alloc>::size_type, const hasher&, const key_equal&, const allocator_type&) [with _Key = std::basic_string<char>; _Tp = std::function<int(const std::vector<std::basic_string<char> >&)>; _Hash = std::hash<std::basic_string<char> >; _Pred = std::equal_to<std::basic_string<char> >; _Alloc = std::allocator<std::pair<const std::basic_string<char>, std::function<int(const std::vector<std::basic_string<char> >&)> > >; std::unordered_map<_Key, _Tp, _Hash, _Pred, _Alloc>::size_type = long unsigned int; std::unordered_map<_Key, _Tp, _Hash, _Pred, _Alloc>::hasher = std::hash<std::basic_string<char> >; std::unordered_map<_Key, _Tp, _Hash, _Pred, _Alloc>::key_equal = std::equal_to<std::basic_string<char> >; std::unordered_map<_Key, _Tp, _Hash, _Pred, _Alloc>::allocator_type = std::allocator<std::pair<const std::basic_string<char>, std::function<int(const std::vector<std::basic_string<char> >&)> > >]’
         RegisteredCommands  commands_   = {};

Using clang 3.7.0:

FAILED: /usr/bin/clang++   -Dcpp_readline_EXPORTS -g -fPIC -I../src  \
-std=c++11 -Wall -Werror -pedantic -Weffc++ -MMD \
-MT src/CMakeFiles/cpp-readline.dir/Console.cpp.o \
-MF src/CMakeFiles/cpp-readline.dir/Console.cpp.o.d \
-o src/CMakeFiles/cpp-readline.dir/Console.cpp.o -c ../src/Console.cpp
../src/Console.cpp:28:43: error: chosen constructor is explicit in copy-initialization
        RegisteredCommands  commands_   = {};
                                          ^~
/usr/lib/gcc/x86_64-pc-linux-gnu/4.9.3/include/g++-v4/bits/unordered_map.h:139:7: note: constructor declared here
      unordered_map(size_type __n = 10,
      ^
1 error generated.

Using exceptions instead of return codes

This is just an idea, but wouldn't it be more C++-like to use exceptions instead of return codes? The Console class could handle those exceptions and automatically print the error messages.