swaggest/php-swagger2-schema

OpenAPI 3.0 / Swagger 2.0 schema PHP mappings

php-swagger2-schema's Issues

Should this check for missing definitions?

Hi. I was trying this out to validate some Swagger 2.0 specs that I auto-generate. I don't see any issues here, so apologies if this library isn't meant for public consumption.

I downloaded the petstore example from OpenAPI as a test.

It passes validation:

<?php
require __DIR__ . '/vendor/autoload.php';
$json = json_decode(file_get_contents(__DIR__ . '/petstore-simple.json'));
$schema = Swaggest\SwaggerSchema\SwaggerSchema::import($json);

But if I change the petstore JSON to reference an invalid definition, it still passes.

For example, I changed line 176 to:

   "definitions": {
     "Pet": {
       "type": "object",
       "allOf": [
         {
-           "$ref": "#/definitions/NewPet"
+           "$ref": "#/definitions/foo"
        },

swagger-parser displays an error when I do this, and it seems to use the same schema. But maybe it does some extra validation. Should this library catch this?

Or if I insert this before line 183, it also passes:

         {
           "required": [
             "id"
           ],
           "properties": {
+            "bad": {
+              "type": "array",
+              "items": {
+                "$ref": "#/definitions/Bad"
+              }
+            },
             "id": {
               "type": "integer",
               "format": "int64"
             }
           }
         }

I was originally trying to use php-json-schema to validate my specs against the Swagger 2.0 schema. The older version 0.12.7 caught the second error but not the first, but the current version doesn't catch either. Which is why I tried this library.